Last Comment Bug 263736 - Group by sort feature with sort by "Date" uses "Old Mail" in RSS folders and newsgroup
: Group by sort feature with sort by "Date" uses "Old Mail" in RSS folders and ...
Status: RESOLVED FIXED
: polish
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: unspecified
: All All
: -- minor (vote)
: Thunderbird 22.0
Assigned To: alta88
:
:
Mentors:
: 267733 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-10-10 08:54 PDT by Kevin Stange
Modified: 2013-02-27 18:42 PST (History)
6 users (show)
mscott: blocking‑aviary1.0-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (862 bytes, patch)
2013-01-12 08:45 PST, alta88
standard8: review+
bwinton: ui‑review-
Details | Diff | Splinter Review
patch (855 bytes, patch)
2013-02-09 10:53 PST, alta88
bwinton: review+
Details | Diff | Splinter Review

Description Kevin Stange 2004-10-10 08:54:18 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041008 Firefox/0.10
Build Identifier: version 0.8 (20041008)

If you group by sort an RSS feed folder on the "Date" field, it uses the string
"Old Mail" for RSS entries aged older than 2 weeks.

Reproducible: Always
Steps to Reproduce:



Expected Results:  
"Old Mail" should probably say "Older Items" or something more generic.
Comment 1 Mike Cowperthwaite 2004-10-10 08:59:22 PDT
xref bug 263678
Comment 2 Marcia Knous [:marcia - use ni] 2004-11-18 15:21:27 PST
or, "Old Articles"?

btw, this also occurs in newsgroups.
Comment 3 Mike Cowperthwaite 2005-01-24 10:15:40 PST
*** Bug 267733 has been marked as a duplicate of this bug. ***
Comment 4 Mike Cowperthwaite 2005-01-24 10:17:07 PST
As noted at the dupe, "Old Mail" doesn't really match the other labels like 
"Today" "Yesterday" etc.
Comment 5 alta88 2013-01-12 08:45:31 PST
Created attachment 701469 [details] [diff] [review]
patch


make the string more generic.  it shouldn't be necessary to change the label:
http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgGroupView.cpp#770
Comment 6 Mark Banner (:standard8, afk until Dec) 2013-02-07 01:48:34 PST
Comment on attachment 701469 [details] [diff] [review]
patch

This should get ui-review sign-off as well.

As this is just an improvement in language we don't need to change the string, but r+ is conditional on also posting to mozilla.dev.l10n when this lands to let them know that we've improved the string and they may want to revisit it in their locales.
Comment 7 Blake Winton (:bwinton) (:☕️) 2013-02-07 07:26:34 PST
Comment on attachment 701469 [details] [diff] [review]
patch

Since none of the other strings mention a noun ("Mail", "Messages"), I don't think we should have a noun in this entry either.  So, ui-r-.

But, if you go with "Older", I'll say ui-r=me.  ;)

(Side note: Outlook apparently uses "Older", too.  http://www.peterbe.com/plog/clever-date-formatting#c051111ajor )

Thanks,
Blake.
Comment 8 alta88 2013-02-09 10:53:57 PST
Created attachment 712168 [details] [diff] [review]
patch
Comment 9 Blake Winton (:bwinton) (:☕️) 2013-02-09 14:28:58 PST
Comment on attachment 712168 [details] [diff] [review]
patch

On the one hand, I think we might want to change the label so that localizers pick up the new string.  On the other hand, we're changing it to match the label itself, and we're not really changing the meaning, just how it sounds.  So I think I'll say r=me, but please double-check in #l10n to see if they would prefer the label to change or not.

Thanks,
Blake.
Comment 10 Théo Chevalier [:tchevalier] 2013-02-14 16:56:38 PST
Is there any particular reason to not change it for SeaMonkey too?
Comment 11 Ryan VanderMeulen [:RyanVM] 2013-02-27 18:42:18 PST
https://hg.mozilla.org/comm-central/rev/a49f5ca048d9

Note You need to log in before you can comment on or make changes to this bug.