263736 - Group by sort feature with sort by "Date" uses "Old Mail" in RSS folders and newsgroup

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Kevin Stange]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041008 Firefox/0.10
Build Identifier: version 0.8 (20041008)

If you group by sort an RSS feed folder on the "Date" field, it uses the string
"Old Mail" for RSS entries aged older than 2 weeks.

Reproducible: Always
Steps to Reproduce:



Expected Results:  
"Old Mail" should probably say "Older Items" or something more generic.

Comment 1

[Mike Cowperthwaite]

xref bug 263678

Comment 2

[Marcia Knous [:marcia]]

or, "Old Articles"?

btw, this also occurs in newsgroups.

Comment 3

[Mike Cowperthwaite]

*** Bug 267733 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Cowperthwaite]

As noted at the dupe, "Old Mail" doesn't really match the other labels like 
"Today" "Yesterday" etc.

Comment 5

[alta88]

Attachment: patch

make the string more generic.  it shouldn't be necessary to change the label:
http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgGroupView.cpp#770

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 701469 [details] [diff] [review]
patch

This should get ui-review sign-off as well.

As this is just an improvement in language we don't need to change the string, but r+ is conditional on also posting to mozilla.dev.l10n when this lands to let them know that we've improved the string and they may want to revisit it in their locales.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 701469 [details] [diff] [review]
patch

Since none of the other strings mention a noun ("Mail", "Messages"), I don't think we should have a noun in this entry either.  So, ui-r-.

But, if you go with "Older", I'll say ui-r=me.  ;)

(Side note: Outlook apparently uses "Older", too.  http://www.peterbe.com/plog/clever-date-formatting#c051111ajor )

Thanks,
Blake.

Comment 8

[alta88]

Attachment: patch

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 712168 [details] [diff] [review]
patch

On the one hand, I think we might want to change the label so that localizers pick up the new string.  On the other hand, we're changing it to match the label itself, and we're not really changing the meaning, just how it sounds.  So I think I'll say r=me, but please double-check in #l10n to see if they would prefer the label to change or not.

Thanks,
Blake.

Comment 10

[Théo Chevalier]

Is there any particular reason to not change it for SeaMonkey too?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/a49f5ca048d9