Closed Bug 263737 Opened 20 years ago Closed 20 years ago

In <commandglue.js>, "Error, Exception, nsIMsgDBView.suppressMsgDisplay, ChangeMessagePaneVisibility"

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8alpha5

People

(Reporter: sgautherie, Assigned: neil)

References

()

Details

(Keywords: regression)

Attachments

(2 obsolete files)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040927] (release) (W98SE)

{{
Error: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgDBView.suppressMsgDisplay]"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://messenger/content/commandglue.js :: ChangeMessagePaneVisibility :: line
749"  data: no]
}}

Reproducible: 100%

Steps:
1. Display a folder with no message in it, and hide the message pane (F8).
(order not relevent)
2. Unhide the message pane (F8).

Result:
You have to press F8 _twice_ for it to work,
because the first time, it aborts with the above exception.
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910] (release) (W98SE)

Works fine: no exception.

+(K) regression.
Keywords: regression
Bug is present with initial line number 748 in v1.8a4.
(my file is modified.)
Neil:
Would you have a clue on this one ?
Or should I go and test (v1.8x) nighlies to find a regression timeframe ?
I've pasted the change that causes this bug in the URL field.
Basically when we unhide the message pane we need to reload the message.
If no message was loaded the old code simply did nothing.
However the new code now throws an exception.
Thunderbird updates the UI first, so it appears to work,
but SeaMonkey updates the back end first, so it fails.
Attached patch Proposed patch (obsolete) — Splinter Review
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #165073 - Flags: superreview?(bienvenu)
Attachment #165073 - Flags: review?(bienvenu)
Comment on attachment 165073 [details] [diff] [review]
Proposed patch

Then I would suggest to change
{{
nsresult rv = NS_OK;
...
if (forceDisplay)
...
rv = GetViewIndexForFirstSelectedMsg(&viewIndex);
}}
to
{{

...
if (forceDisplay)
...
nsresult rv = GetViewIndexForFirstSelectedMsg(&viewIndex);
}}
too, if it applies !?
Attachment #165100 - Flags: superreview+
Attachment #165100 - Flags: review+
Attachment #165073 - Attachment is obsolete: true
Attachment #165073 - Flags: superreview?(bienvenu)
Attachment #165073 - Flags: review?(bienvenu)
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha5
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attachment #165100 - Attachment description: Alternate version → Alternate version [Checked in: Comment 8]
Attachment #165100 - Attachment is obsolete: true
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: