263755 - #ifndef XP_MACOSX the Alt+D shortcut, because it doesn't work on Mac

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Russ]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10

Select Location Bar Keyboard Shortcut Opt+D does not work.  Alternate shorcuts
Cmd+L and F6 work as expected.

Reproducible: Always
Steps to Reproduce:
1. Click Opt+D
Actual Results:  
Nothing happens.

Expected Results:  
The Location Bar should be selected.

This worked at one point in previous versions of Firefox (0.8 I believe).

Comment 1

[Arthur Wiebe]

Reproduced on
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041002
Firefox/0.10.1

alt/option + D does not select the location bar as it says it does in Firefox Help.

Comment 2

[Jo Hermans]

did they forget it in bug 231381 ?

Comment 3

[Aaron Leventhal]

I don't think Alt+D is supposed to work on Mac. Does it for Seamonkey?
Accel+L should work, Ctrl+D might even work if they implemented it with
acceesskey="D".

Anyway, it's probably the Firefox help doc that should be changed.

Comment 4

[Russ]

Opt+D works on Internet Explorer 5.2 for Mac.  Familiar IE shortcuts like 
Cmd+Return (Ctrl+Enter) and Opt+D (Alt+D) are key features of FireFox, 
especially for former users of IE, and are key to have across platform for 
FireFox to have consistent usability.  This shortcut worked in previous 
versions of FireFox, but stopped working along with the 9 other shortcuts 
which I've submitted separately.  Please do not remove this feature.  It is 
reason #2 why I prefer FireFox over Safari on Mac, and is critical for 
consistency across platforms (I use FireFox on several platforms).

Comment 5

[ender.mb]

Having option+d select the url bar would be bizarre, as it ordinarily enters a
special character which can be used in type-ahead find, text boxes, etc. This
can lead to some strange behavior--for example, the Sage extension uses
option+s. This means that I can't reliably enter whatever character option+s
produces--most of the time, Sage pops up instead. It's generally not a good idea
to use the option key (by itself) for shortcuts on the Mac.

Comment 6

[Russ]

(In reply to comment #5)
> Having option+d select the url bar would be bizarre, as it ordinarily enters a
> special character which can be used in type-ahead find, text boxes, etc. This
> can lead to some strange behavior--for example, the Sage extension uses
> option+s. This means that I can't reliably enter whatever character option+s
> produces--most of the time, Sage pops up instead. It's generally not a good idea
> to use the option key (by itself) for shortcuts on the Mac.

Agreed.  I'm changing the component to Help Documentation, which should be
updated to remove the Opt+D Select Location Bar Keyboard Shortcut.

Comment 7

[Jeff Walden (gone starting June 8)]

This is fallout from the bugfix for Opt/Cmd displaying on the Mac.

(In reply to comment #6)
> Agreed.  I'm changing the component to Help Documentation, which should be
> updated to remove the Opt+D Select Location Bar Keyboard Shortcut.

When you change the component, please use the "Reassign bug to owner and QA
contact of selected component" option so as to make sure the QA contact changes
accordingly.  Several people watch firefox.help-documentation@bugs to track Help
bugs, and there's no way we'll see these bugs unless we get mail about them (or
if we happen to notice them on saved Bugzilla queries).

I might get to a patch for this pretty soon...as there shouldn't be any wording
changes I'll probably just check in the fix and bypass review (assuming I make
the patch).

Comment 8

[Jeff Walden (gone starting June 8)]

(In reply to comment #7)
> This is fallout from the bugfix for Opt/Cmd displaying on the Mac.

Okay, maybe it really wasn't. ;-)

Anyways, fix checked into branch and trunk to remove the shortcut from Help.  If
Opt+D isn't good for the Mac, you should probably make it official (or
better-documented, if that's how you choose to see it) by changing the
definition of the shortcut in browser/base/content/browser-sets.inc by enclosing
it in #ifndef XP_MACOSX/#endif:

http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser-sets.inc#201

Please report other mistakes in Mac keyboard shortcuts while you're at it.  No
one working on Help uses a Mac, so we're sort of stuck with what we can derive
from source code (unless other people tell us otherwise), which doesn't consist
of every Mac shortcut.

Comment 9

[Jeff Walden (gone starting June 8)]

Attachment: #ifndef XP_MACOSX for the Alt+D shortcut

This is against trunk.	I don't know or really care if it applies to aviary,
because aviary can live without this (and if it can't, porting the patch is
trivial).

Comment 10

[Jeff Walden (gone starting June 8)]

Comment on attachment 161907 [details] [diff] [review]
#ifndef XP_MACOSX for the Alt+D shortcut

Mike doesn't have time to review anything right now, even things as trivial as
this.  I asked for a review of a patch that directly corresponded to a patch
for the same problem in another area of the app.  You'll need to find someone
else to do the review for you.

Comment 11

[Steffen Wilberg]

The Help doc is fixed, see comment 8. -> Keyboard Navigation.

Comment 12

[Asaf Romano (gone)]

Comment on attachment 161907 [details] [diff] [review]
#ifndef XP_MACOSX for the Alt+D shortcut

should be reviewed by Aaron.

Comment 13

[Aaron Leventhal]

I'm fine with removing Alt/Option+D for Mac, based on the comment that
option+letter is used to enter extended chars. However, I had wanted the code to
be r='d by a front-end person like mconnor.

Comment 14

[Asaf Romano (gone)]

Comment on attachment 161907 [details] [diff] [review]
#ifndef XP_MACOSX for the Alt+D shortcut

lets move it to vladimir

Comment 15

[Mike Connor [:mconnor]]

Comment on attachment 161907 [details] [diff] [review]
#ifndef XP_MACOSX for the Alt+D shortcut

hmm, as much as the key-compatibility with other Mac browsers is a "good thing"
the Opt+whatever shortcuts obviously shouldn't be used in this case.

r=[e-mail]

Comment 16

[Steffen Wilberg]

-> Jeff.

Comment 17

[Steffen Wilberg]

Checking in mozilla/browser/base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.30; previous revision: 1.29