263759 - Remove Ctrl+F4 (Close Window) shortcut for Macs (it conflicts with a default OS setting)

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Russ]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10

Pressing Cmd+F4 Close Tab Keyboard Shortcut does not work.  Alternate shortcut
Cmd+W does work as expected.

Reproducible: Always
Steps to Reproduce:
1. Press Cmd+F4 in open tab
Actual Results:  
Nothing happens

Expected Results:  
Tab should close

Comment 1

[Asaf Romano (gone)]

This is by design. Ctrl+F4 is a windows-standard for closing tabs (and it is is
not the primary keyboard shortcut anyway)

Use Command+W.

Comment 2

[Russ]

Needs to be updated in Help documentation.  I am unable to reassign b ug to owner and QA contact of 
selected componet.  Please Change status to New and reassign...thanks.

Comment 3

[Jeremy M. Dolan]

summary/owner/qa changes as requested.

Comment 4

[Jeff Walden (gone starting June 8)]

Cmd+F4 doesn't work because from what I can see, the shortcut is specifically
Ctrl+F4 (it works based on event.ctrlKey, not "accel" in @modifiers in XBL). 
Does the shortcut Ctrl+F4 work on the Mac?  Based on my reading of the following
source code, Ctrl+F4 should indeed work properly.

http://lxr.mozilla.org/aviarybranch/source/toolkit/content/widgets/tabbrowser.xml#1532

Until I can get this confirmed or not confirmed, I can't make the change without
having personally tested it (which won't happen as I don't have a Mac).

Comment 5

[Asaf Romano (gone)]

(In reply to comment #4)
> Cmd+F4 doesn't work because from what I can see, the shortcut is specifically
> Ctrl+F4 (it works based on event.ctrlKey, not "accel" in @modifiers in XBL). 
> Does the shortcut Ctrl+F4 work on the Mac?

Well, control+f4 works _only_ if you disable the *default* OS keyboard shortcut
for "Focus on window (active) or next window" (that means it doesn't work for
most of the mac user base) so it should be removed from the help system.

Anyway, i'll open a separate bug for disabling Control+F4 on mac.

Comment 6

[Asaf Romano (gone)]

bug 264145

Comment 7

[Jeff Walden (gone starting June 8)]

Shortcut removed for Macs.  I updated it to be ctrlKey specifically instead of
accelKey as well.  Fixed branch/trunk.

Comment 8

[Asaf Romano (gone)]

(In reply to comment #7)
> Shortcut removed for Macs.  I updated it to be ctrlKey specifically instead of
> accelKey as well.  Fixed branch/trunk.

In the help only, right?