263762 - remove Opt+F4 from shortcut list for FF-Mac and IE-Mac

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Russ]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041009 Firefox/0.10

Opt+F4 Close Window Keyboard Shortcut does not work.  Alternate shorcut
Shift+Cmd+F4 shortcut does work.

Reproducible: Always
Steps to Reproduce:
1. Press Opt+F4 in open window

Actual Results:  
Nothing

Expected Results:  
Window should close

Comment 1

[Asaf Romano (gone)]

Alt+d4 is a windows standard only, need to remove this one from help system

Comment 2

[Steffen Wilberg]

Remove the shortcut from where? From the keyboard reference doc in Help? Or from
the Help viewer? Or maybe from everywhere?

Comment 3

[Russ]

Help Documentation needs updated for both Firefox and IE since Opt+F4 is not the shortcut for Close 
Window.

Note, Opera DOES implement Opt+F4 for its Close 
Window Keyboard Shortcut

Please update component to Help Documentation and reassign bug to owner and QA contact of 
selected component (I do not have rights to do so), unless there is some reason it should be Help 
Viewer.

Comment 4

[Steffen Wilberg]

Attachment: patch

I can't find the code for Opt+F4 right now, so I can't check whether it's
intentionally disabled on Mac.

This patch removes Opt+F4 from the shortcut list for Mac Firefox and Mac IE.

Comment 5

[Steffen Wilberg]

Comment on attachment 163274 [details] [diff] [review]
patch

We've already noMac'ed Opt+F4 for Close Tab. Now we need to do this for Close
Window as well.

I'm requesting approval as well until somebody says it's still not necessary.

Comment 6

[Steffen Wilberg]

*** Bug 265853 has been marked as a duplicate of this bug. ***

Comment 7

[Steffen Wilberg]

The Close Tab and Close Window menu items were swapped by bug 248021 (branch
checkin 2004-09-25 08:32).

Comment 8

[Steffen Wilberg]

Attachment: also place Close Window above Close Tab

Comment 9

[Steffen Wilberg]

Just ignore comment 6-8.
I need more sleep.

Comment 10

[Steffen Wilberg]

Comment on attachment 163274 [details] [diff] [review]
patch

Rerequesting review and approval on the first patch.

Comment 11

[Jeff Walden (gone starting June 8)]

Comment on attachment 163274 [details] [diff] [review]
patch

r=me

Bonus points to you if you can think of a good way to add &accelKey+W and
emphasize that it closes the window /only/ if only one tab is opened.  That
should be done iff it can be done so that it isn't confusing.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 163274 [details] [diff] [review]
patch

a=asa

Comment 13

[Steffen Wilberg]

Attachment: this is what I checked in

<td>Close Tab<br/>Close Window if only one Tab is open</td>

Comment 14

[Steffen Wilberg]

Checked in br & trunk.

Comment 15

[Jeff Walden (gone starting June 8)]

(In reply to comment #13)
> <td>Close Tab<br/>Close Window if only one Tab is open</td>

For Ctrl+W this is true; however, Ctrl+F4 doesn't close the window if only one
tab is open.  Perhaps we should file a bug?

Personally, I think going back to the way it was in the original patch might be
the best bet.  (It doesn't /really/ matter, but it would be correcter.)  It's
not quite as informative, but Ctrl+F4 for Close Window is just wrong.

Comment 16

[Steffen Wilberg]

Argh, I didn't know that. Reopening. I'll remove the "Close Window if only one
Tab is open" part once the tree reopens.

Comment 17

[Steffen Wilberg]

Attachment: remove "Close Window if only one Tab is open"

Comment 18

[Steffen Wilberg]

Comment on attachment 163466 [details] [diff] [review]
remove "Close Window if only one Tab is open"

This addresses Jeff's comment 15, so marking r+.
Seeking approval.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 163466 [details] [diff] [review]
remove "Close Window if only one Tab is open"

a=asa

Comment 20

[Steffen Wilberg]

Checked in br & trunk.