263832 - F1 key for Day View clashes with Help key in Windows

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Rod Whiteley]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Win98; rv:1.7.3) Gecko/20040913 Firefox/0.10

F1 is usually reserved for Help.  The key assignments for views should be changed.

The current CalendarHelp prototype simply changes Day View to F5, but this is
probably not the best choice.

I think this might be better:

  Day View    F2
  Week View   F3
  Multiweek   F4
  Month View  F5


Reproducible: Always
Steps to Reproduce:
1. Start Calendar
2. Press F1
Actual Results:  
Calendar switched to Day View

Expected Results:  
Help window opens, or message telling me that no help is installed.

Comment 1

[Wm]

Hmmmmn.  I'm inclinded to agree.

But think it should be an enhancement rather than a bug (or if a bug then
trivial) as once you know it is there ...

Comment 2

[Richard Klein]

Attachment: changes view keys to 1-4 + accel

This patch changes the keys for views from F1-F4 to accel+1 - accel+4.	This
should keep view switching from interfering with function keys.  This also
matches the keys for switching tabs in firefox.  

This patch only includes changes for en-US locale.

Comment 3

[Richard Klein]

Comment on attachment 164458 [details] [diff] [review]
changes view keys to 1-4 + accel

Requesting review of patch

Comment 4

[Matthew (lilmatt) Willis]

Attachment: rev0 - trunk - patch changes key bindings to all locales

Patch changes day, week, multiweek, and month views to accel+1,2,3,4
respectively for Sunbird, and shift+accel+1,2,3,4 for xpi. 

Seamonkey uses accel+1,2,4 to switch between browser, mail, etc.

Comment 5

[Richard Klein]

Comment on attachment 164458 [details] [diff] [review]
changes view keys to 1-4 + accel

Removing review request since new patch has been added.

Comment 6

[Mostafa Hosseini]

Comment on attachment 164587 [details] [diff] [review]
rev0 - trunk - patch changes key bindings to all locales

Checked in.Thanks

Comment 7

[Mostafa Hosseini]

Fixed in CVS.

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!