Sunbird Options dialog has blank content pane, nsPrefWindow is not defined

RESOLVED INVALID

Status

RESOLVED INVALID
14 years ago
13 years ago

People

(Reporter: gekacheka, Assigned: mostafah)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: cvs Sunbird

content/prefs/nsPrefWindow.js uses '#' as a comment character for the license
block.  (Recent builds have removed the license block, which is probably not the
best fix.)

Fix is to comment the license block with /*   */.




Reproducible: Always
Steps to Reproduce:
1. Tools | JavaScript Console  (open JavaScript console to see errors)
2. Tools | Options

Actual Results:  
Options window:  Icons appear in left pane, ok & cancel butons appear, but
content pane is blank.  Clicking on icons in left pane does not make a difference.

JavaScriptConsole says:

Error: illegal character
Source File: chrome://calendar/content/pref/nsPrefWindow.js
Line: 1
Source Code:
# -*- Mode: Java; tab-width: 4; c-basic-offset: 4; -*-

Error: nsPrefWindow is not defined
Source File: chrome://calendar/content/pref/pref.xul
Line: 31
Or to preprocess the file. (as other toolkit apps do)
(Reporter)

Comment 2

14 years ago
Created attachment 161765 [details] [diff] [review]
nsPrefWindow.js patch: change license block comments from '#' to /* */
(Reporter)

Updated

14 years ago
Attachment #161765 - Flags: first-review?(mostafah)
I think useing the preprocessor would be better. Otherwise, we would fork this
file more, for no reason.
(Assignee)

Comment 4

14 years ago
Comment on attachment 161765 [details] [diff] [review]
nsPrefWindow.js patch: change license block comments from '#' to /* */

As mvl said the correct fix is to use the xul preprocessor which we already do.
Attachment #161765 - Flags: first-review?(mostafah) → first-review-
(Assignee)

Comment 5

14 years ago
The instance of that file being used has not gone through the xul preprocessor
so this bug is invalid.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → INVALID
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.