263869 - Sunbird Options dialog has blank content pane, nsPrefWindow is not defined

Status: RESOLVED INVALID

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: cvs Sunbird

content/prefs/nsPrefWindow.js uses '#' as a comment character for the license
block.  (Recent builds have removed the license block, which is probably not the
best fix.)

Fix is to comment the license block with /*   */.




Reproducible: Always
Steps to Reproduce:
1. Tools | JavaScript Console  (open JavaScript console to see errors)
2. Tools | Options

Actual Results:  
Options window:  Icons appear in left pane, ok & cancel butons appear, but
content pane is blank.  Clicking on icons in left pane does not make a difference.

JavaScriptConsole says:

Error: illegal character
Source File: chrome://calendar/content/pref/nsPrefWindow.js
Line: 1
Source Code:
# -*- Mode: Java; tab-width: 4; c-basic-offset: 4; -*-

Error: nsPrefWindow is not defined
Source File: chrome://calendar/content/pref/pref.xul
Line: 31

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Or to preprocess the file. (as other toolkit apps do)

Comment 2

[gekacheka]

Attachment: nsPrefWindow.js patch: change license block comments from '#' to /* */

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

I think useing the preprocessor would be better. Otherwise, we would fork this
file more, for no reason.

Comment 4

[Mostafa Hosseini]

Comment on attachment 161765 [details] [diff] [review]
nsPrefWindow.js patch: change license block comments from '#' to /* */

As mvl said the correct fix is to use the xul preprocessor which we already do.

Comment 5

[Mostafa Hosseini]

The instance of that file being used has not gone through the xul preprocessor
so this bug is invalid.

Comment 6

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!