263903 - redirects with a body not cached properly

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We don't seem to cache redirects with a body.  If I serve an Apache asis file
containing:

Status: 301 Moved Permanently
Location: http://www.mozilla.org/
Cache-Control: max-age=86400
Content-Type: text/plain
                                                                               
http://www.mozilla.org/

and load it twice in the same browser session, I get two hits on the server. 
The second load, an NSPR log shows:

Cached data size does not match the Content-Length header
[content-length=24 size=0]

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I was actually seeing this on an aviary branch build, but darin thinks it's on
the trunk as well and has been around for a while.)

Comment 2

[Boris Zbarsky [:bzbarsky]]

See
http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/http/src/nsHttpChannel.cpp#741
(the "don't store the response body for redirects" comment).

Comment 3

[Darin Fisher]

Attachment: v1 patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 162666 [details] [diff] [review]
v1 patch

So this just skips doing the content-length comparison and ensuing cache
invalidate for cases when we have a redirect?

If so, sr=bzbarsky.  If I misunderstood something, please tell me what.  ;)

Comment 5

[Darin Fisher]

> So this just skips doing the content-length comparison and ensuing cache
> invalidate for cases when we have a redirect?
> 
> If so, sr=bzbarsky.  If I misunderstood something, please tell me what.  ;)

you are correct.  the alternative would have been to strip the Content-Length
header before inserting the headers into the cache, but since i realized that we
also have the same bug for HEAD responses, i figured it was best to put all of
the checking into CheckCache.

Comment 6

[Darin Fisher]

fixed-on-trunk