263940 - delete nonexistent cookie: prefs dialog OK button doesn't work

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dan M]

Tools -> Options -> Privacy -> Cookies -> View Cookies
Delete at least one cookie
Scroll to the bottom of the list
Lo! What are all these blank lines at the end of the list? Select one...
Delete the blank line
Click OK to exit the View Cookies dialog
Click OK to exit Preferences
-- Nothing happens. OK is a dead button.
   You can cancel out of the dialog. There is a JavaScript error.

No similar error seems to exist in a 20041006 Suite trunk build.

Comment 1

[Dan M]

Attachment: can't select nonexistent cookies to delete

This patch fixes the problem by disallowing the user from selecting deleted
cookies in the first place. Without this patch, treeUtils.js attempts to access
a property of the view object named _rowCount. There is no such property. Using
the real property seems like a good and safe thing, so I'm going to hit the
block? switch, just to ensure someone looks at it.

Curious thing about this patch, it exactly reverses revision 1.5.4.2 of
treeUtils.js on the Aviary branch. The checkin comment for that revision blames
ben and cites bug 250898. The patch posted in that bug makes no mention of this
file.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 161802 [details] [diff] [review]
can't select nonexistent cookies to delete

r+a=[e-mail]

land now! now!

Comment 3

[Steffen Wilberg]

(In reply to comment #1)
> Curious thing about this patch, it exactly reverses revision 1.5.4.2 of
> treeUtils.js on the Aviary branch. The checkin comment for that revision blames
> ben and cites bug 250898. The patch posted in that bug makes no mention of this
> file.
It's part of the first patch in bug 250898.

Comment 4

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change