263951 - In <mailCommands.js>, "Error: redeclaration of const NS_BAYESIANFILTER_CONTRACTID"

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[timeless]

problem:
Error: redeclaration of const NS_BAYESIANFILTER_CONTRACTID
Source File: chrome://messenger/content/mailCommands.js
Line: 508

reason:
/mailnews/base/search/resources/content/ABSearchDialog.xul, line 42 --
<?xul-overlay href="chrome://messenger/content/mailWindowOverlay.xul"?>
/mailnews/base/search/resources/content/ABSearchDialog.xul, line 76 --
<script src="chrome://messenger/content/mailCommands.js"/>
/mailnews/base/resources/content/mailWindowOverlay.xul, line 61 -- <script
type="application/x-javascript" src="chrome://messenger/content/mailCommands.js"/>
/mailnews/base/resources/content/mailCommands.js, line 519 -- const
NS_BAYESIANFILTER_CONTRACTID =
"@mozilla.org/messenger/filter-plugin;1?name=bayesianfilter";

Comment 1

[Justin Wood (:Callek)]

Attachment: Removing erroneous <script .../>

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 162971 [details] [diff] [review]
Removing erroneous <script .../>

Heard dmose is much more active than sspitzer

Comment 3

[[e-mail]]

Attachment: Alternative approach

If you don't need the offline indicator or the (unused) progress meter, then we
can simply remove the entire mail window overlay.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Is there some reason not to apply both of these patches?  If the <script /> is
actually not required, it's just gonna cost time and memeory.

Comment 5

[Justin Wood (:Callek)]

Dan, I am not sure personally, but I think at least one instance of the script
is needed, though keep in mind I am not a mailnews person, nor is it in my main
interest. (just triaging some of Timeless's bugs).  If none of the effects of
that script are used/useful, go ahead and use both, if they are, I personally
suggest removing the overlay, if it does not remove anything useful either.

Comment 6

[[e-mail]]

Good point... you only need strres.js ABSearchDialog.js and abCommon.js

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050503] (nightly) (W98SE)

(Moved but still there)
{{
Error: redeclaration of const NS_BAYESIANFILTER_CONTRACTID
Source File: chrome://messenger/content/mailCommands.js
Line: 527
}}

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050701] (nightly) (W98SE)

What is needed to move forward ? (ask for reviews, prepare a third patch, ...)

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.8) Gecko/20050511] (release) (W98SE)

Bug present in MAS v1.7.x branch too...

{{
Error: redeclaration of const NS_BAYESIANFILTER_CONTRACTID
Source File: chrome://messenger/content/mailCommands.js
Line: 478
}}

Comment 10

[Mark Banner (:standard8)]

I've had a brief discussion with Neil on IRC and we've decided that what we want
for this is something similar to what was done for SearchDialog.xul - see
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=SearchDialog.xul&branch=&root=/cvsroot&subdir=mozilla/mailnews/base/search/resources/content&command=DIFF_FRAMESET&rev1=1.69&rev2=1.70

Basically - copy the required components of the mailWindowOverlay.xul status bar
(and anything else if there is, I don't believe so) to ABSearchDialog.xul, and
remove the then redundant script statements.

At the moment the required parts of the status bar that I think we need are the
status text and the offline status. I don't know if we want progress indication
 I assume its unused at the moment - we could always put that back in later. The
offline status I think would be worth keeping because of ldap address books.

So, if someone would like to come up with a new patch we'll try and get this
resolved.

Comment 11

[Mark Banner (:standard8)]

Just discussed with Callek, I'll come up with a new patch for this (as per my
previous comments) in the next day or so.

Comment 12

[Mark Banner (:standard8)]

Attachment: Combined patch (checked in branch+trunk)

This patch removes the extra script, and moves the status bar definition
(reduced) from mailWindowOverlay.xul to ABSearchDialog.xul.

Comment 13

[[e-mail]]

Comment on attachment 193067 [details] [diff] [review]
Combined patch (checked in branch+trunk)

Feel free to kill any of the other scripts if you find that they're unused.

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 193067 [details] [diff] [review]
Combined patch (checked in branch+trunk)

r=dmose.  Would this patch be relevant to Thunderbird also?

Comment 15

[Serge Gautherie (:sgautherie)]

(In reply to comment #14)
> (From update of attachment 193067 [details] [diff] [review] [edit])
> r=dmose.  Would this patch be relevant to Thunderbird also?

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

I don't know about the patch, but I don't get this error(s) in TB.

Comment 16

[Mark Banner (:standard8)]

Comment on attachment 193067 [details] [diff] [review]
Combined patch (checked in branch+trunk)

I just checked this in:

/cvsroot/mozilla/mailnews/base/search/resources/content/ABSearchDialog.xul,v 
<--  ABSearchDialog.xul
new revision: 1.16; previous revision: 1.15

Comment 17

[Mark Banner (:standard8)]

(In reply to comment #14)
> (From update of attachment 193067 [details] [diff] [review] [edit])
> r=dmose.  Would this patch be relevant to Thunderbird also?

As Serge says, we don't think the bug is there. However a quick look reveals
that we might to remove some of the scripts like we did in this one - I'll check
later & leave this bug open for now to remind me.

Comment 18

[Justin Wood (:Callek)]

Comment on attachment 193067 [details] [diff] [review]
Combined patch (checked in branch+trunk)

Requesting 1.8 branch approval. This is a patch which removes a JS Strict
Error, and adds some cleanup.

SeaMonkey Only, unless my head is lying to me.

Comment 19

[Mark Banner (:standard8)]

Comment on attachment 193067 [details] [diff] [review]
Combined patch (checked in branch+trunk)

I've just checked this into the 1.8 branch.

Comment 20

[Mark Banner (:standard8)]

Attachment: Thunderbird version (checked in)

As I noted in my comments before, Thunderbird doesn't have this bug, however it
does include some unnecessary js files in ABSearchDialog.xul, so this patch
removes them.

Comment 21

[David :Bienvenu]

Comment on attachment 194051 [details] [diff] [review]
Thunderbird version (checked in)

just make sure that implementing the "Write" command from the search results
doesn't require either of these files.

Comment 22

[Mark Banner (:standard8)]

(In reply to comment #21)
> (From update of attachment 194051 [details] [diff] [review] [edit])
> just make sure that implementing the "Write" command from the search results
> doesn't require either of these files.

It actually uses AbNewMessage in abCommon.js which gets the compose service and
then starts the compose window from there.

Comment 23

[Mark Banner (:standard8)]

Comment on attachment 194051 [details] [diff] [review]
Thunderbird version (checked in)

I just checked this into trunk.

Comment 24

[Mark Banner (:standard8)]

I'm not going to request approval for the thunderbird verison of the patch for
the branch as its just a script include change, however if you want it David,
feel free to request approval.

Comment 25

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050827 SeaMonkey/1.1a]
(nightly) (W98SE)

V.Fixed