263962 - Document more Mac-only menu stuff

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Jeff Walden (gone starting June 8)]

See bug 263246 comment 1 for a description.  I don't know how much we'll get to
for 1.0 (and thus it isn't late-l10n or blocking bug 253104 yet), but I'm not
sure what sort of demands we can put on localizers for 1.0mac.  In any case this
should definitely be done for then.

Comment 1

[Steffen Wilberg]

The "Firefox menu" mentioned in bug 263246 comment 1 is the same for every Mac
app AFAIK. I don't think we need to document that. Neither "Minimize" etc.

Comment 2

[Steffen Wilberg]

*** Bug 266843 has been marked as a duplicate of this bug. ***

Comment 3

[Asaf Romano (gone)]

(In reply to comment #1)
> The "Firefox menu" mentioned in bug 263246 comment 1 is the same for every Mac
> app AFAIK. I don't think we need to document that. Neither "Minimize" etc.

We don't need to document "Hide All", "Show All", but we do need to document
"Quit", "Minimize", "Zoom" and "Preferences"

Comment 4

[Steffen Wilberg]

From the dupe:
Quit is in the Firefox menu, not in the File menu.
Preferences in the Firefox menu, not in the Tools menu.
(We've already changed the Mac menu path in bug 265741.)

Is the list from bug 263246 comment 1 correct:
Firefox menu
------------
About Mozilla Firefox
Preferences...
Services (not yet implemented?)
Hide Firefox
Hide Others
Show All
Quit Firefox

Window menu
-----------
Mimimize (not working)
Zoom (aka, maximize --also not working)
Bring All to Front (also not working)
[list of Firefox windows, by <title>]

Comment 5

[Asaf Romano (gone)]

(In reply to comment #4)

> (We've already changed the Mac menu path in bug 265741.)

In  Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3)
Gecko/20041030 Firefox/1.0RC2 help docs., it's still listed in "Tools"

> Is the list from bug 263246 comment 1 correct:
> Firefox menu
> ------------
> About Mozilla Firefox
> Preferences...
> Quit Firefox

Only those should be documented.
 
> Window menu
> -----------
> Mimimize (not working)
> Zoom (aka, maximize --also not working)

both working in latest builds.

> Bring All to Front (also not working)

Yep, we shoudn't document this one.

Comment 6

[Steffen Wilberg]

> > (We've already changed the Mac menu path in bug 265741.)
> 
> In  Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3)
> Gecko/20041030 Firefox/1.0RC2 help docs., it's still listed in "Tools"
That's both false and true. The menu reference still lists Preferences in Tools.
Bug 265741 changed the menu path. That describes the way to open the Preferences
dialog, e.g. in the menu reference->Go->Home, it should say "select Firefox > 
Preferences and open the General panel".

Comment 7

[Steffen Wilberg]

-> me. We need to fix this ASAP as 1.0Mac is likely to be released on Nov 9 as
well: http://www.mozilla.org/projects/firefox/roadmap.html

Comment 8

[Steffen Wilberg]

Where is the Window menu located?

Comment 9

[Asaf Romano (gone)]

(In reply to comment #8)
> Where is the Window menu located?

between Tools to Help

Comment 10

[Steffen Wilberg]

Almost done.
What does Minimize do? Minimize the current window? Or minimize all Firefox
windows including Extensions, Download Manager etc.? I'm on #documentation btw.

Comment 11

[Hiro]

(In reply to comment #10)
> Almost done.
> What does Minimize do? Minimize the current window? Or minimize all Firefox
> windows including Extensions, Download Manager etc.? I'm on #documentation btw.

current window is minimized ;-)

Comment 12

[Hiro]

additional comment:
However, the Window menu does not work correctly like bug262201,etc. except Camino.

Comment 13

[Steffen Wilberg]

Attachment: patch

Adds Firefox and Windows menus. In the document, I've put it inside <div
class="mac>. It makes no sense to show this on other platforms. In the toc,
I've added "(Mac only)". I've merely copied the descriptions for the Firefox
menu items from their original locations.

And I've removed File->Quit, Tools->Preferences, and Help->For IE users on Mac.
The latter is not shown in the Help menu on Mac indeed (#ifndef XP_UNIX).

Comment 14

[Steffen Wilberg]

Attachment: patch v1.1

Comment 15

[Steffen Wilberg]

Comment on attachment 164100 [details] [diff] [review]
patch v1.1

This is somewhat late, but it wasn't me who decided to ship 1.0Mac on Nov. 9.

I worked with Mano on IRC and he said it looks good on Mac.

Comment 16

[Asaf Romano (gone)]

The 1.0mac is going to be removed very soon, use 1.0?

Comment 17

[Jeff Walden (gone starting June 8)]

Comment on attachment 164100 [details] [diff] [review]
patch v1.1

>   <rdf:Description about="#menu-help">
>     <nc:subheadings>
>       <rdf:Seq>
>         <rdf:li> <rdf:Description ID="menu-help-help-contents" nc:name="Help Contents" nc:link="menu_reference.xhtml#help_contents"/> </rdf:li>
>         <rdf:li> <rdf:Description ID="menu-help-for-ie-users" nc:name="For Internet Explorer Users" nc:link="menu_reference.xhtml#for_ie_users"/> </rdf:li>
>         <rdf:li> <rdf:Description ID="menu-help-promote" nc:name="Promote &brandShortName;" nc:link="menu_reference.xhtml#promote"/> </rdf:li>
>         <rdf:li> <rdf:Description ID="menu-help-about-mozilla-firebird" nc:name="About &brandFullName;" nc:link="menu_reference.xhtml#about_mozilla_firebird"/> </rdf:li>
>       </rdf:Seq>

Do all these still display on the Mac?	Double-check and mark those that don't
as " (Windows or Linux)".  (I'm particularly looking at About.)  Also, if For
IE is Win-only, mark it as " (Windows)".

>   <h3 id="exit">
>     <span class="win">Exit</span>
>-    <span class="noWin">Quit</span>
>+    <span class="unix">Quit</span>
>   </h3>
>   <p>Closes all opened windows in &brandShortName;, including any active downloads,
>     and exits &brandShortName; completely. If you happen to select this menu item with
>     open tabs, windows, or downloads, &brandShortName; will ask you to confirm your
>     choice to prevent accidental exits.</p>

Wrap this in a <div class="noMac"/> please.  You're just leaving the entry but
hiding the header for it on the Mac now.

>+    <h3 id="zoom">Zoom</h3>
>+    <p>Enlarges or Restores the current window.</p>

Remove caps on the Restores.

>+    <h3 id="open-windows">(Open Windows)</h3>
>+    <p>This menu also displays all the open windows by their title.</p>

Remove "also", unless I'm not thinking properly.

Give it a double-check before posting the revised version, please, and with
those changes r=me.  I don't have time right now to look at this any further
due to real life.  Still hoping it can get in in time...

Comment 18

[Steffen Wilberg]

Mano, can you please list the items in the Help menu on Mac? Thanks.

Comment 19

[Asaf Romano (gone)]

(In reply to comment #18)
> Mano, can you please list the items in the Help menu on Mac? Thanks.

Help Contents
Promote Firefox
About Mozilla Firefox

Comment 20

[Steffen Wilberg]

Attachment: patch v1.2

> Do all these still display on the Mac?
Yes, Except "For IE Users".
> Also, if For IE is Win-only, mark it as " (Windows)".
Done.
 
> Wrap this in a <div class="noMac"/> please.
Oops, done.

> Remove caps on the Restores.
Done.
 
> Remove "also", unless I'm not thinking properly.
I was referring to additional items below Minimize and Zoom. But it looks right
without it, so I removed it.

Comment 21

[Steffen Wilberg]

Comment on attachment 164642 [details] [diff] [review]
patch v1.2

(from comment #17)
> with those changes r=me

Requesting approval.

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 164642 [details] [diff] [review]
patch v1.2

land today, or not at all. 

a=[e-mail]

Comment 23

[Steffen Wilberg]

Checked in branch & trunk.