263974 - A profile name with a space causes the startup script to parse options incorrectly

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Isaac]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

Line 166 of the "firefox" script reads

        [ $i = ${_optLast} ] && break

$i iterate through all options; and ${_optLast} is one of the options as well. 
If the option contains anything that has an option that contains a space, $i
will expand to two words, and the "=" test will fail, saying that there are more
arguments than expected.


Reproducible: Always
Steps to Reproduce:
1.Make a profile, using the default "Default User" as profile name.
2.Start firefox using that profile with "firefox -P 'Default User'".

Actual Results:  
A warning is shown in the terminal showing that options are not parsed correctly.


Expected Results:  
The variables mentioned should be guarded by quotes, i.e.,

        [ "$i" = "${_optLast}" ] && break

Comment 1

[Yusuf Goolamabbas]

Attachment: patch which adds quote marks

patch which adds the quote marks

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 161839 [details] [diff] [review]
patch which adds quote marks

Let's land the patch from bug 251772 instead, that will sync with the trunk.

Comment 3

[Benjamin Smedberg]

Fixed by bug 251772