263989 - Virtual folders should have a different icon

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To see the difference between normal folders and virtual folders within the
folderpane, we should use a different icon for the virtual folders. 

Virtual folders could be removed without losing the displayed mails. Doing the
same for normal folders deletes all existing mails within this mbox. So it is a
 very important elementary feature.

Comment 1

[sairuh (rarely reading bugmail)]

scott, cc arvid if he is interested/available to do more artwork here. :)

Comment 2

[Marcia Knous [:marcia]]

Scott: can we get this on the radar for 1.0 or 1.1?

Comment 3

[John T. Haller (email is bugzilla2@)]

Attachment: Proposed Search Folder (Closed) Icon

Comment 4

[John T. Haller (email is bugzilla2@)]

Attachment: Proposed Search Folder (Open) Icon

I've attached a quick possibility.  Use the standard folders with a small
version of the magnifying glass from the search bar super-imposed over them. 
Thoughts?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

How sweet. :) I'ld ave one proposal: The magnifying glass is moved to the right
when opening the folder and moved to the left when closing it. IMO it should
stay at the same position and could be solved by moving the glass to the right
for attachment 164697 [details]?

Asking for a blocker of TB1.0 and that we don't miss it.

Comment 6

[John T. Haller (email is bugzilla2@)]

(In reply to comment #5)
> How sweet. :) I'ld ave one proposal: The magnifying glass is moved to the right
> when opening the folder and moved to the left when closing it. IMO it should
> stay at the same position and could be solved by moving the glass to the right
> for attachment 164697 [details]?

Do you mean mirrored so that the handle switched to the righthand side?  I would
think it would be better to keep the same perspective.  Saying it should be
moved and stay at the same position threw me a bit in your comment.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, I havn't proposed a mirrored view. Open your icons inside two tabs and look
at them by switching back and forward. You will notice that the magnifying glass
in the second one is staying two or three pixels away from the other one. It's
just minor but it could look ugly when having multiple virtual folders saved
near each other and viewing them in different states.

Comment 8

[John T. Haller (email is bugzilla2@)]

Attachment: Proposed Search Folder (Closed) Icon

Henrik, I see what you mean.  Here's a one that fixes pixel-alignment issue for
closed search folder.

Comment 9

[Scott MacGregor]

we have a new theme update coming from arvid. I'm not tracking these things in
individual bugs for each item getting updated. minusing

Comment 10

[kaeptn00]

I personaly find that the magnifying  glass is a tid bid too small. Compare to
the more clearly visible clues and gadgets on the other icons.  Like the
detailed clock on the unsent messages or the recyle arrows on the trash can.

The looking glas is too small. Make a screenshot of the panel and put the new
one in between the others and you might be convinced that it looks a bit "hungry" ;)

Suggestions: Do we need to see the full handle? Is it possible to make the
highlight of the glass visible?

Comment 11

[John T. Haller (email is bugzilla2@)]

Attachment: Proposed Search Folder (Open) Icon 2

Comment 12

[John T. Haller (email is bugzilla2@)]

Attachment: Proposed Search Folder (Closed) Icon 2

Comment 13

[John T. Haller (email is bugzilla2@)]

(In reply to comment #10)
> I personaly find that the magnifying  glass is a tid bid too small. Compare to
> the more clearly visible clues and gadgets on the other icons.  Like the
> detailed clock on the unsent messages or the recyle arrows on the trash can.
> 
> The looking glas is too small. Make a screenshot of the panel and put the new
> one in between the others and you might be convinced that it looks a bit
"hungry" ;)
> 
> Suggestions: Do we need to see the full handle? Is it possible to make the
> highlight of the glass visible?

Well, here's another possibility with the magnifier a tad larger. (Proposed Icon 2)

Comment 14

[Mike Cowperthwaite]

*** Bug 270467 has been marked as a duplicate of this bug. ***

Comment 15

[sairuh (rarely reading bugmail)]

looks like this has been fixed when bug 270477 landed.

Comment 16

[sairuh (rarely reading bugmail)]

looks nice, too!