263990 - Virtual folders can't be deleted

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

version 0.8 (20041010)

Trying to delete a virtual folder removes it from the folderpane and also
deletes the two files inside the file system. But after restarting Thunderbird
the virtual folder and the files are already recreated. So it's impossible to
delete any virtual folder.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looking closer to this bug shows that virtualFolders.dat is not updated when
removing a virtual folder. 

Comment 2

[David :Bienvenu]

yes, that's what's going on...

Comment 3

[David :Bienvenu]

actually, we do update the virtualfolders.dat - but I think sometimes we fail to
delete the underlying .msf file for the virtual folder, and then when you
restart, we re-create the virtual folder from the .msf file. Are these imap or
local folders?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, i manually deleted both files (also the .msf) but the virtual folder was
recreated after restart. I had to clear the entry within the virtualfolders.dat
to stop it.

Comment 5

[David :Bienvenu]

how did you delete the virtual folder? Through the UI? In that case, we do write
out virtualFolders.dat - were these local folders or imap?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes, I deleted the folder over the UI. It was located under the inbox of a pop
account.

Comment 7

[David :Bienvenu]

Attachment: proposed fix

we weren't writing out the virtual folders.dat in the case where you didn't
have any virtual folders, so the last virtual folder would remain...

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

perfect.

v.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh, I verified to fast. David did you checked in on branch and trunk?

Comment 10

[David :Bienvenu]

yes, I checked into the trunk and branch. Where did you have a problem, and what
was the scenario? (there's a separate problem where you may have to delete the
.msf file and corresponding folder if they get left after a delete - is that the
case? I've got a fix for when this happens with IMAP, but haven't dealt with
local folders yet)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, there is no problem. AFAIR a bug can be marked as verified only when the
patch is landed on the branch and trunk. Otherwise my information was wrong and
sorry for the excitement.

Comment 12

[David :Bienvenu]

I'm not sure what the rule is there - some fixes we don't want for the branch,
so it can't be a hard and fast rule :-) but the general rule is:

If we mark it fixed, that means fixed on the trunk, unless otherwise specified
in a comment.
If we add the fixed-aviary1.0 keyword, that means fixed on the branch

Comment 13

[David :Bienvenu]

*** Bug 263348 has been marked as a duplicate of this bug. ***