263992 - Menus placed at wrong position (directly under the window border)

Status: VERIFIED FIXED

(Core :: Web Painting, defect)

Description

[Frank Wein [:mcsmurf]]

Happens with a current trunk build, when you open the File Menu (or Edit, or
Help, doesn't matter), the menu isn't placed under the menu item, but directly
under the window border. For a screenshot, see the URL.
Roc: i think this is caused by your checkin from Bug 238493 (Need to
(re)implement widget change caching). Backing out your patch locally fixed the
problem here.

Comment 1

[Bill Mason]

*** Bug 264080 has been marked as a duplicate of this bug. ***

Comment 2

[Bill Mason]

*** Bug 264086 has been marked as a duplicate of this bug. ***

Comment 3

[Stephen Walker]

Attachment: Copy nsWindow::Move's borderless parent code to nsWindow::Resize

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 161911 [details] [diff] [review]
Copy nsWindow::Move's borderless parent code to nsWindow::Resize

I'll sr+ since it's pretty trivial but since I basically wrote it, Ere should
review

Comment 5

[Bill Mason]

*** Bug 264207 has been marked as a duplicate of this bug. ***

Comment 6

[Bill Mason]

*** Bug 264221 has been marked as a duplicate of this bug. ***

Comment 7

[Bill Mason]

Raising severity, added smoketest kw per duped bug 264221.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in. Thanks stephen!

Comment 9

[Tracy Walker [:tracy]]

I filed bug 264229 (autocomplete not working) and bug 264235 (context menus not
working) against mac trunk.  Might they be related to this?  

Comment 10

[Frank Wein [:mcsmurf]]

*** Bug 264169 has been marked as a duplicate of this bug. ***

Comment 11

[R.K.Aa.]

*** Bug 264267 has been marked as a duplicate of this bug. ***

Comment 12

[u52928]

(In reply to comment #11)
> *** Bug 264267 has been marked as a duplicate of this bug. ***

I think the behavior I reported on 12 Oct under 264213 - which has now been put
under 98830 - was related to this problem. 

It appeared 11 Oct and was fixed 13 Oct. Looking at the details of this one, I 
no longer think the problem I reported really had anything to do with my
dual-monitor setup but rather with this. 

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 264213 has been marked as a duplicate of this bug. ***

Comment 14

[Bill Mason]

V 20041014 PC/Win2000

Comment 15

[Tracy Walker [:tracy]]

bug 264229 (autocomplete not working) and bug 264235 (context menus not
working) on mac trunk were not fixed by the patch here.  Can someone take a look
at those blockers?

Comment 16

[AKIHIRO Misaki (a.k.a Kuden)]

This bug is not corrected completely.
Arbitrary window sizes -> Press F11 key -> Returns to the original size
Bookmarks menu on Menubar placed at wrong position.

Comment 17

[Frank Wein [:mcsmurf]]

(In reply to comment #16)
> This bug is not corrected completely.
> Arbitrary window sizes -> Press F11 key -> Returns to the original size
> Bookmarks menu on Menubar placed at wrong position.

Right, it seems the popup window of the Go Menu, the Bookmarks Menu and the
Tools Menu have this problem. 

Comment 18

[Frank Wein [:mcsmurf]]

(In reply to comment #17)
> (In reply to comment #16)
> > This bug is not corrected completely.
> > Arbitrary window sizes -> Press F11 key -> Returns to the original size
> > Bookmarks menu on Menubar placed at wrong position.
> 
> Right, it seems the popup window of the Go Menu, the Bookmarks Menu and the
> Tools Menu have this problem. 

Hm, seems even all menus are affected at some window size.

Comment 19

[HJ]

I have some problems with: <tooltip position="before_start"... 

Tooltips are now displayed on top of the menu and that's not right. It doesn't
matter what I use for attribute position because they all fail to work after the
patch for bug 238493.

Note that it worked in Mozilla builds up to 20040507 but is broken since Mozilla
build 20040508.

Comment 20

[Boris Zbarsky [:bzbarsky]]

HJ, stop spamming bugs with unrelated comments.  The bug 238493 fix landed 5
MONTHS after the build in which you claim your thing stopped working.

Comment 21

[HJ]

(In reply to comment #20)
> HJ, stop spamming bugs with unrelated comments.  The bug 238493 fix landed 5
> MONTHS after the build in which you claim your thing stopped working.

"stop spamming bugs"

I've add only two comments in the last 5 months or so, so don't bullshit me.
Also they told me (IRC) to add this comment here so try to nail other people
down because I won't let you!

Comment 22

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Javier, this is probably related to bug 264235 that I told you about.

Comment 23

[Robert O'Callahan (:roc) (email my personal email if necessary)]

oh, this is Windows now. Hmm

Comment 24

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Does the patch in bug 264245 fix this bug on Windows?

https://bugzilla.mozilla.org/attachment.cgi?id=162696&action=view

Comment 25

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Martjin, if you could test your build against the comments here...

Comment 26

[Martijn Wargers (dead)]

(In reply to comment #24)
> Does the patch in bug 264245 fix this bug on Windows?
> 
> https://bugzilla.mozilla.org/attachment.cgi?id=162696&action=view
Well, I have momentarely my build patched with the "fixv2" and the "Windows
fix?" patches from bug 264245.
These seem to fix the bugs mentioned in comment 16 and comment 17 (pressing F11
and returning to normal size then opening bookmarks).

Comment 27

[Robert O'Callahan (:roc) (email my personal email if necessary)]

excellent!

Comment 28

[Robert O'Callahan (:roc) (email my personal email if necessary)]

now that those patches are checked in, I'm marking this fixed on the basis of
what Martjin said

Comment 29

[Tracy Walker [:tracy]]

verified with windows mozilla trunk build 2004-11-10-06-trunk