263997 - nsMsgCopyService does not provide OnProgress notifications to the nsIMsgCopyServiceListener

Status: NEW

(MailNews Core :: Backend, defect)

Description

[Paul Tomlin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

nsIMsgCopyServiceListener provides an OnProgress(progress, progressMax) method
but it is not called by nsMsgCopyService at:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgCopyService.cpp

Reproducible: Always
Steps to Reproduce:
var msgCopyListener =
{
	OnProgress: function (progress, progressMax)
	{
		dump('msgCopyListener::OnProgress(' + progress + ', ' + progressMax + ')');
	},
	OnStartCopy: function ()
	{
		dump('msgCopyListener::OnStartCopy()');
	},
	OnStopCopy: function (status)
	{
		dump('msgCopyListener::OnStopCopy(' + status + ')');
	},
	SetMessageKey: function (key)
	{
		dump('msgCopyListener::SetMessageKey(' + key + ')');
	}
};

var msgCopyService = 
  Components.classes['@mozilla.org/messenger/messagecopyservice;1']
    .getService(Components.interfaces.nsIMsgCopyService);

// assume src and dst are valid nsIMsgFolder, messages is an
//  nsISupportsArray of 3 nsIMsgHdr
msgCopyService.CopyMessages(
    src, messages, dst, false, msgCopyListener, null, false
  );

Actual Results:  
msgCopyListener::OnStartCopy()
msgCopyListener::OnStopCopy(0)

Expected Results:  
msgCopyListener::OnStartCopy()
msgCopyListener::OnProgress(1, 3)
msgCopyListener::OnProgress(2, 3)
msgCopyListener::OnProgress(3, 3) <-- not sure if this is expected to occur
msgCopyListener::OnStopCopy(0)

The copy/move works as expected but there is simply no notification as to the
progress of the operation.

I can't find any reference to OnProgress in 
http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgCopyService.cpp
so I'm assuming that the method was forgotten or its notification not yet
implemented.

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Paul Tomlin]

Still evident in 1.0.7

I can't track through the C++ well enough to see where/if this should be put in.
The CopyMessages methods appear to be partially handled by the Local/Imap/News
specific handlers, nsMsgCopyService just handing off an array of messages to be
copied/moved en-mass.

Comment 3

[David :Bienvenu]

Have you tried this with trunk builds? 1.07 contains mainly security fixes, not
general bug fixes.

Comment 4

[Paul Tomlin]

Attachment: Quick File 0.15 with maxVersion at 2.0+

By installing this in Thunderbird, enabling debug in the options and moving a
number of messages in one go, you should see OnProgress(x, y) via dump().

Reference: quickfile.js#383, quickfile.js#407

Comment 5

[Paul Tomlin]

Not tried in on trunk as I don't have it installed. Thought the extension might
make it easier for someone who has to confirm/deny it's existance.

Obviously this bug has languished quietly for a while, if it's genuine then I
don't know that anyone else has noticed it.

Comment 6

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 7

[IagoSRL]

Bug 555976 is related with this.