264002 - wpad: DNS lookup before PAC call unnecessary

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[benc]

from bug 28998, #83, I said:
I'm not sure why we add all the DNS stuff like:

+    rv = dnsService->AsyncResolve(NS_LITERAL_CSTRING("wpad"), PR_TRUE, this, curQ,
+                                  getter_AddRefs(request));

We only support doing A rec lookups right? So why don't we just set the PAC URL
and load it, it is going to lookup "wpad" when the URL tries to connect. If a
PAC load fails, then we use "DIRECT" always anyhow.

Comment 1

[Darin Fisher]

> We only support doing A rec lookups right?

I'm not sure what you mean by this.  We ask the OS to resolve "wpad" to an IP
address, and it may return a list of IPv6 and/or IPv4 addresses.  How it manages
to return that list is well beyond our purview.


> So why don't we just set the PAC URL and load it, it is going to lookup "wpad" 
> when the URL tries to connect.

Yeah, good point.  I don't understand why we are doing a DNS query here either.
 Shaver?

Comment 2

[Mike Shaver (:shaver emeritus)]

Vestigial and harmless, I thought, from when I was trying to find a safe way to
do the domain-walk.  I would not object to its removal at all.

Comment 3

[Darin Fisher]

fixed-on-trunk with patch for bug 282442

Comment 4

[benc]

V/fixed, inspected patch.
Thanks.