Focus remains in the menu after middleclick

RESOLVED INCOMPLETE

Status

()

Firefox
Menus
--
minor
RESOLVED INCOMPLETE
13 years ago
7 years ago

People

(Reporter: Dorando, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [closeme 2010-04-21])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10

.

Reproducible: Always
Steps to Reproduce:
1. Set following prefs:
browser.tabs.loadBookmarksInBackground to true
browser.tabs.loadFolderAndReplace to false
2. Goto a page with scrollbar ( http://planet.mozilla.org/ ).
3. Make sure the content has focus (try scrolling via keyboard)
4A. Middleclick on Help->Promote Firefox
4B. Middleclick on Bookmarks->Bookmarks Toolbar Folder->Getting Started
4C. Middleclick on Bookmarks->Bookmarks Toolbar Folder
5. Press Down (VK_DOWN)

Actual Results:  
The previously used menu opens.


Expected Results:  
The view of the original tab should scroll.
(Reporter)

Comment 1

13 years ago
Created attachment 161852 [details] [diff] [review]
patch against aviary
(Reporter)

Updated

13 years ago
Attachment #161852 - Flags: review?(mconnor)
I'm away from Mozilla for the near to medium future, please try to find another
reviewer.
(Reporter)

Updated

13 years ago
Attachment #161852 - Flags: review?(mconnor) → review?(bryner)
Comment on attachment 161852 [details] [diff] [review]
patch against aviary

I'd much prefer using .focus() instead of synthesizing left click events that
didn't happen.	Can you get that to work?
(Reporter)

Comment 4

13 years ago
Created attachment 167420 [details] [diff] [review]
double .focus() instead of .click()

Seems to have the same effect.
Attachment #161852 - Attachment is obsolete: true
(Reporter)

Updated

13 years ago
Attachment #167420 - Flags: review?(bryner)
(Reporter)

Updated

13 years ago
Attachment #161852 - Flags: review?(bryner)
Comment on attachment 167420 [details] [diff] [review]
double .focus() instead of .click()

Ok, we shouldn't need both window.focus() and window._content.focus().	Just
doing the second one should be sufficient.  Does that work?
(Reporter)

Comment 6

13 years ago
(In reply to comment #5)
> Ok, we shouldn't need both window.focus() and window._content.focus().	Just
> doing the second one should be sufficient.  Does that work?
> 
Sadly not. Only the first one is able to close the menu, but the focus seems to
get lost. Note, that the .click(); returned the focus to the previous selected
object, while the .focus(); always focuses the content.

It would likely be better to change whatever causes the menu to close on left
clicks to also do this on middle click.
cc'ing aaronl, who has done some work with that menu code iirc

Updated

12 years ago
Assignee: firefox → nobody
QA Contact: bugzilla → menus
Comment on attachment 167420 [details] [diff] [review]
double .focus() instead of .click()

minusing to get off of my review list... sounds like the approach of causing
the menu to close on middle click the same way it closes on left click would be
preferable.
Attachment #167420 - Flags: review?(bryner) → review-

Comment 9

11 years ago
WFM-  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

Firefox's top level menus are unresponsive to middle clicks now.
This bug was reported on Firefox 2.x or older, which is no longer supported and will not be receiving any more updates. I strongly suggest that you update to Firefox 3.6.3 or later, update your plugins (flash, adobe, etc.), and retest in a new profile. If you still see the issue with the updated Firefox, please post here. Otherwise, please close as RESOLVED > WORKSFORME
http://www.mozilla.com
http://support.mozilla.com/kb/Managing+profiles
http://support.mozilla.com/kb/Safe+mode
Whiteboard: [closeme 2010-04-21]
No reply, INCOMPLETE. Please retest with Firefox 3.6.x or later and a new profile (http://support.mozilla.com/kb/Managing+profiles). If you continue to see this issue with the newest firefox and a new profile, then please comment on this bug.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.