264021 - magic.gov.uk topic selection dialog fails when new windows are opened into tabs

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[David Janes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041011 Firefox/0.10.1

The above site uses legitimate popups extensively. When "Force links that open
new windows to open in" is set these popups open in a new tab/current window and
cause the site to not function correctly.

I didn't think this feature affected popups but instead simply trapped
target="_blank" and redirected it to a new tab/current window?

Reproducible: Always
Steps to Reproduce:
1. Select Tools | Options and set "Force links that open new windows to open in"
on the advanced tab.
2. Visit http://www.magic.gov.uk
3. Click on Interactive Map
4. Select "design my own topic" from the Select Topic dropdown
5. Select a couple of topics and click done.
Actual Results:  
Nothing happens!

Expected Results:  
Similar to what happens when "Force links that open new windows to open in" is
disabled.

*** This feature only exists in the post-PR nightlys so doesn't apply to any
before that ***

Comment 1

[David Janes]

According to the nightly build log browser.link.open_newwindow.restriction
should be set to 2 by default, but is set to 0 instead (on the build i'm using).

Setting it to 2 fixes this problem. Should this be the default?

Comment 2

[Dan M]

Several readings of this bug report have convinced me that the reporter intends
for new windows to be opened into new tabs; a clarification maddeningly
disguised in the initial comment. In this case the "Design my Own Topic" dialog
fails for the same reason as bug 263844. I'm marking this bug dependent on that
one and I'm adjusting the summary for accuracy.

If the reporter really did mean to open new windows into the current
tab/window... that's just never going to work with a page like this. I've opened
bug 264395 to cover that aspect of single window mode.

Comment 3

[David Janes]

I'm sorry if my bug report was vague - I meant that this functionality fails
when "Force links that open new windows to open in" is set regardless of if its
the same tab or a new tab.

I can see why it would never work in the same tab (now dealt with by bug
264395), but there's no reason why it can't be fixed for a new tab.
Again if browser.link.open_newwindow.restriction is set to 2 then it works
either way.

Comment 4

[David Janes]

This now seems to work when using a new tab, but bug 264395 still stands for
Single Window Mode.

Comment 5

[David Janes]

Bug 266759 has disabled the UI for this functionality in 1.0.
This will need to be revisited after then.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I can no longer reproduce this bug. Please re-open if this is still an issue.