264059 - "copy email address" in context menu is broken

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

"Copy email address" in the Firefox context menu is broken on the trunk.  I
really don't see how it ever worked, actually.  Perhaps recent XPConnect changes
broke it somehow.

I'm not sure why we have helper functions for getService, etc., and then not use
them most of the time, but if we do, we may as well use them correctly.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hmm, javascript:alert(Components.interfaces.nsIClipboardHelper) shows
nsIClipboardHelper, so actually I'd sort of expect it to work, even though it's
a bit odd.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Steps to reproduce:
 1) right click on the "David Baron" within " ------- Additional Comment #1 From
David Baron  2004-10-12 11:12 PDT  [reply] -------" above.
 2) select "Copy email address"
 3) try to paste it somewhere

Actual results: whatever was on clipboard before is pasted
Expected results: paste [e-mail]


Also, the error I got without the patch was:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80570018 (NS_ERROR_XPC_BAD_IID) [nsIJSCID.getService]"  nsresult: "0x80570018
(NS_ERROR_XPC_BAD_IID)"  location: "JS frame ::
chrome://browser/content/browser.js :: anonymous :: line 3582"  data: no]

Comment 4

[Raphael Segun Awoseyin]

I was able replicate this bug using Firefox on a Win XP Pro (Service Pack 2) system. Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060120 Firefox/1.5.0.1

The first day I tried this, I experienced the bug. But it never happened again after that. Try using the latest Firefox build.

Comment 5

[Peter 'vt100' Schwindt]

Confirmed using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060728 BonEcho/2.0b1

Comment 6

[Marcia Knous [:marcia]]

This bug bites me all the time when I am dogfooding bonecho, since I create a lot of watch aliases in bugzilla. Just for the record this works in Firefox 1.5.0.x.

Comment 7

[martin raud]

(In reply to comment #5)
> Confirmed using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
> rv:1.8.1b1) Gecko/20060728 BonEcho/2.0b1
> 

Confirmed here also, using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060728 BonEcho/2.0b1

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Do you see the error in comment 3 on the Error Console (or JavaScript Console)?

Comment 9

[Peter 'vt100' Schwindt]

There's nothing to be seen on the Error Console

Comment 10

[:Gavin Sharp [email: [e-mail]]]

The recent reports of "Copy email" not working are most likely bug 346403 (which only affected 2006-07-28 branch builds).