264088 - theme update doesn't remove previous version

Status: VERIFIED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[sairuh (rarely reading bugmail)]

couldn't find an existing bug on this, but dup as needed. tested using
2004101209-0.9+ on linux fc2.

1. install a compatible theme for which there exists a newer version. for
example, SphereGnome (for linux) 0.9.7.4 works (0.9.7.7 is the latest as of this
writing).

https://update.mozilla.org/themes/moreinfo.php?id=166&vid=874&page=releases

2. open the Theme manager window, select SphereGnome (or whichever theme you
want to update), and hit the Update button.

3. in the resulting Update wizard, follow steps to install the newer version.

expected results: the older theme should be replaced with the newer one in the
Theme manager.

actual results: both versions of the theme are still listed. still persists even
after quitting and restarting Firefox.

Marcia, Tracy: could you see if this also occurs on Mac and/or Windows? also,
please note what theme you test with. thanks!

Comment 1

[Tracy Walker [:tracy]]

Tried theme 708090 version 1.47 then updated on Windows XP.  Theme manager only
shows the latest updated version 1.48.

Comment 2

[Marcia Knous [:marcia]]

Sarah: on the Mac, Using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.7.3) Gecko/20041012 Firefox/0.10, I installed the same theme Tracy did
(708090 version 1.47) and then upgraded to 1.48. Note that in my case I did
install the theme first(1.47) and then hit the upgrade button - I did get the
dialog that there was a 1.48 and was able to install it. The installed version
was 1.48.

I then tried a different variation, installation Curacao 1.11 and then hit
update without the theme engaged. Unfortunately, it did not find the 1.12 update
which makes me think there is some strangeness with our update mechanism, as I
saw this with a few other themes as well.

Comment 3

[sairuh (rarely reading bugmail)]

(In reply to comment #2)
> I installed the same theme Tracy did
> (708090 version 1.47) and then upgraded to 1.48. Note that in my case I did
> install the theme first(1.47) and then hit the upgrade button - I did get the
> dialog that there was a 1.48 and was able to install it. The installed version
> was 1.48.

but was v1.47 removed after you updated?

> I then tried a different variation, installation Curacao 1.11 and then hit
> update without the theme engaged. Unfortunately, it did not find the 1.12 update
> which makes me think there is some strangeness with our update mechanism, as I
> saw this with a few other themes as well.

yeah, I've also seen something like this, too, but I think it should be filed as
a separate issue.

Comment 4

[Marcia Knous [:marcia]]

(In reply to comment #3)
> (In reply to comment #2)
> > I installed the same theme Tracy did
> > (708090 version 1.47) and then upgraded to 1.48. Note that in my case I did
> > install the theme first(1.47) and then hit the upgrade button - I did get the
> > dialog that there was a 1.48 and was able to install it. The installed version
> > was 1.48.
> 
> but was v1.47 removed after you updated?  Yes, Version 1.47 was removed and
there was only one version of the theme. Sorry for not including that earlier.
> 
> > I then tried a different variation, installation Curacao 1.11 and then hit
> > update without the theme engaged. Unfortunately, it did not find the 1.12 update
> > which makes me think there is some strangeness with our update mechanism, as I
> > saw this with a few other themes as well.
> 
> yeah, I've also seen something like this, too, but I think it should be filed as
> a separate issue.
> 
> 

Comment 5

[Marcia Knous [:marcia]]

I was just able to reproduce this bug on the Mac using the same theme that Sarah
did - I installed SphereGnome 0.9.6.2. I then clicked the update button and it
did find a newer version, 0.9.7.7 and installed it. I then selected the newer
theme and restarted FF, and both versions of the theme still show in the UI.

Comment 6

[sairuh (rarely reading bugmail)]

(In reply to comment #5)
> I was just able to reproduce this bug on the Mac using the same theme that Sarah
> did - I installed SphereGnome 0.9.6.2. I then clicked the update button and it
> did find a newer version, 0.9.7.7 and installed it. I then selected the newer
> theme and restarted FF, and both versions of the theme still show in the UI.

could this perhaps be an issue with the GnomeSphere theme, and not Firefox? I'll
test with the 708090 theme (if it'll work on linux)...

Comment 7

[sairuh (rarely reading bugmail)]

(In reply to comment #6)
> test with the 708090 theme...

interesting, on Linux I experience what tracy and marcia saw: the newer theme
replaces the older one in the Themes mgr. odd.

if this is a 3rd party theme issue, feel free to mark invalid. otherwise, keep
it open if this is exposing a bug on how firefox (or u.m.o.?) handles updating.

Comment 8

[alanjstr]

Probably a dupe of 251026

Comment 9

[Nickolay_Ponomarev]

*** Bug 271220 has been marked as a duplicate of this bug. ***

Comment 10

[Ed Hume]

The issue with SphereGnome 0.9.7.7 is specific to the theme and to the version
numbers. Beginning with 0.9.7.7 I changed the theme's ID. On the theme's home
page I note this, and tell users to uninstall the old version before installing
the new one.

In any case, it is a "feature" and not really a bug. Further, it should no
longer be relevant since the release of FF 1.0. I recommend closing out this bug.

Comment 11

[Tracy Walker [:tracy]]

verified