264096 - check if NSS is initialized before calling NSS functions

Status: NEW

(Core :: Security: PSM, defect, P3)

Description

[Andrew Schultz]

from bug 263799:

------- Additional Comment #5 From Robert Relyea 2004-10-11 14:07 PDT [reply]
-------

In some sense this is a latent bug in the application. It's calling NSS
functions even when NSS has not been initialized. Since PK11_LogoutAll has up to
this point been accidentally safe, NSS, at the very least, should continue to
allow calls to PK11_LogoutAll to occur even if NSS is not initialized (in this
case it will continue to be a noop). This will allow bug for bug binary
compatibility with previous versions of NSS. I'll attach a patch to make it so..

bob


------- Additional Comment #13 From Robert Relyea 2004-10-11 15:41 PDT [reply]
-------

I think it would be a good idea to bracket the calls with

if (NSS_IsInitialized()) {
}

in code fragments that are trying shutdown NSS even if it wasn't already shutdown.

bob

Comment 1

[Kai Engert (:KaiE:)]

Sounds reasonable and simple to do.

Comment 2

[Kai Engert (:KaiE:)]

reassign bug owner.
mass-update-kaie-20120918

Comment 3

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.