264106 - Crash on launch: chrome://browser/content/hiddenWindow.xul can't be resolved

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10.1

Attempting to launch Sunbird (20041012) fails. The chrome URL
chrome://browser/content/hiddenWindow.xul cannot be resolved. hiddenWindow.xul
currently is found at chrome://global/content/hiddenWindow.xul

Reproducible: Always
Steps to Reproduce:
1. Build Sunbird on OSX with debug on
2. Launch Sunbird ($ open Sunbird.app/Contents/MacOS/sunbird-bin)
3. Watch it fail and note the debug output




This is from a single launch and failure of Sunbird:

ec000761:~ mwillis$
/Volumes/data/cvs/sunbird/mozilla/dist/Sunbird.app/Contents/MacOS/sunbird-bin; exit
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsINIParser.cpp, line 51
Type Manifest File: /Users/mwillis/Library/Application
Support/Sunbird/Profiles/iwox2u9t.default/xpti.dat
nsNativeComponentLoader: autoregistering begins.
*** Registering application components (all right -- a generic module!)
*** Registering nsAutoConfigModule components (all right -- a generic module!)
*** Registering nsSecurityManagerModule components (all right -- a generic module!)
*** Registering nsChromeModule components (all right -- a generic module!)
*** Registering docshell_provider components (all right -- a generic module!)
*** Registering nsEditorModule components (all right -- a generic module!)
*** Registering embedcomponents components (all right -- a generic module!)
*** Registering nsGfxMacModule components (all right -- a generic module!)
*** Registering nsLayoutModule components (all right -- a generic module!)
*** Registering nsPluginModule components (all right -- a generic module!)
*** Registering nsParserModule components (all right -- a generic module!)
*** Registering nsI18nModule components (all right -- a generic module!)
*** Registering nsIconDecoderModule components (all right -- a generic module!)
*** Registering nsImageLib2Module components (all right -- a generic module!)
*** Registering nsJarModule components (all right -- a generic module!)
*** Registering nsMorkModule components (all right -- a generic module!)
*** Registering nsFindComponent components (all right -- a generic module!)
*** Registering necko_core_and_primary_protocols components (all right -- a
generic module!)
*** Registering appshell components (all right -- a generic module!)
*** Registering BOOT components (all right -- a generic module!)
*** Registering NSS components (all right -- a generic module!)
*** Registering PKI components (all right -- a generic module!)
*** Registering nsPrefModule components (all right -- a generic module!)
*** Registering nsRDFModule components (all right -- a generic module!)
*** Registering nsTransactionManagerModule components (all right -- a generic
module!)
*** Registering nsUConvModule components (all right -- a generic module!)
*** Registering Browser_Embedding_Module components (all right -- a generic module!)
*** Registering nsWidgetMacModule components (all right -- a generic module!)
*** Registering xpcomObsoleteModule components (all right -- a generic module!)
*** Registering xpconnect components (all right -- a generic module!)
*** Registering oeICalModule components (all right -- a generic module!)
*** Registering nsSoftwareUpdate components (all right -- a generic module!)
nsNativeComponentLoader: autoregistering succeeded
nsNativeComponentLoader: registering deferred (0)
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsINIParser.cpp, line 51
nsNativeComponentLoader: autoregistering begins.
nsNativeComponentLoader: autoregistering succeeded
nsNativeComponentLoader: registering deferred (0)
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsINIParser.cpp, line 51
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsINIParser.cpp, line 51
WARNING: Creation of "{47049e42-1d87-482a-984d-56ae185e367a}" in progress
(Reentrant GS - see bug 194568), file nsComponentManager.cpp, line 1806
++WEBSHELL == 1
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsChromeRegistry.cpp,
line 613
WARNING: chrome: failed to get base url for
chrome://browser/content/hiddenWindow.xul -- using wacky default, file
nsChromeRegistry.cpp, line 548
Couldn't convert chrome URL: chrome://browser/content/hiddenWindow.xul
++DOMWINDOW == 1
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsWebShellWindow.cpp,
line 327
###!!! ASSERTION: HiddenWindow not created: 'NS_SUCCEEDED(rv)', file
nsAppShellService.cpp, line 480
Break: at file nsAppShellService.cpp, line 480
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsAppRunner.cpp, line 1939
WARNING: nsExceptionService ignoring thread destruction after shutdown, file
nsExceptionService.cpp, line 191
nsMenuX 0
nsMenuItemX 0
nsStringStats
 => mAllocCount:           5142
 => mReallocCount:           81
 => mFreeCount:            5141  --  LEAKED 1 !!!
 => mShareCount:           3765
 => mAdoptCount:           1414
 => mAdoptFreeCount:       1413  --  LEAKED 1 !!!

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - trunk - patch fixes chrome url in sunbird.js (default prefs)

This patch changes the path to hiddenWindow.xul to the correct location of
chrome://mozapps/content/hiddenWindow.xul

It also removes a couple stray tabs in the file.

(Note the error in my initial description: hiddenWindow.xul's chrome URL should
be mozapps, not global)

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - patch creates new hiddenWindow.xul and abstracts commandsets/keysets out to menuOverlay.xul

This patch requires the following other files:
? content/hiddenWindow.js
? content/hiddenWindow.xul
? content/menuOverlay.js

Comment 3

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - additional file: hiddenWindow.js goes in mozilla/calendar/sunbird/base/content/

Comment 4

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - additional file: hiddenWindow.xul goes in mozilla/calendar/sunbird/base/content/

Comment 5

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - additional file: menuOverlay.js goes in mozilla/calendar/sunbird/base/content/

Comment 6

[Matthew (lilmatt) Willis]

Attachment: rev2 - trunk - backs out whitespace changes to make code changes more readable

All other rev1 files are still relevant

Comment 7

[Matthew (lilmatt) Willis]

Attachment: rev3 - trunk - new files to be added to mozilla/calendar/sunbird/base/content/

This patch has been revised to use the "include" style that Firefox uses. It's
much cleaner, and I feel more confident in the quality of rev3 than I do of
rev2 or rev1. 

This not only fixes the crashing problem, but on the Mac it also creates the
drop down menus (File, Edit, etc.) when you've closed the main calendar window.


The contents of this .tgz should be added to
mozilla/calendar/sunbird/base/content/

Comment 8

[Matthew (lilmatt) Willis]

Attachment: rev3 - trunk - new style of patch - supersedes revs 1 and 2

Comment 9

[Matthew (lilmatt) Willis]

One more note: this patch means
mozilla/calendar/sunbird/base/content/menuOverlay.xul is no longer used and can
be removed.

Comment 10

[Matthew (lilmatt) Willis]

Attachment: rev5 - trunk - more cleanups - this one is for real

- Is now ONE patch file! (go cvsutils and mvl!)
- adds MPL tri-license to all files
- adds "Window" menu for Mac OS X
- fixes some key bindings, abstracting them out to .dtds
  (THIS REQUIRES ATTACHMENT 162497 [details] [diff] TO BE CHECKED IN TO WORK)
  https://bugzilla.mozilla.org/attachment.cgi?id=162497&action=view

Comment 11

[Matthew (lilmatt) Willis]

Attachment: rev6 - trunk - I really mean it this time... it's for real (forgot to add Print key)

Yeah... I know what I said about the last patch. I forgot to add a key to
"Print" so accel+P works.

This one REALLY is the one.

Comment 12

[Matthew (lilmatt) Willis]

Attachment: rev7 - trunk - with print fix

Comment 13

[Matthew (lilmatt) Willis]

Attachment: rev8 - trunk - removed need for preprocessor on Preferences menu for OSX - see inline comments in calendar-menubar.inc

Comment 14

[Matthew (lilmatt) Willis]

Attachment: rev9 - trunk - fixed comments that bothered xml parser on clean rebuild

This is getting downright comical. 
This should be good enough to check in for now.

Comment 15

[Matthew (lilmatt) Willis]

Attachment: rev10 - trunk - fixed my own problem with diff

Comment 16

[Mostafa Hosseini]

Comment on attachment 162601 [details] [diff] [review]
rev10 - trunk - fixed my own problem with diff

To begin with, license	blocks in .inc files should be commented with # in
order to be removed by the xul preprocessor otherwise they will show up in the
final compiled .xul  file

Comment 17

[Matthew (lilmatt) Willis]

Attachment: rev12 - trunk - fixed comments on .inc files, included "Window" menu code from FF

Comment 18

[Mostafa Hosseini]

Comment on attachment 163724 [details] [diff] [review]
rev12 - trunk - fixed comments on .inc files, included "Window" menu code from FF

Patch checked in with some tweaks.

Comment 19

[Mostafa Hosseini]

Fixed in CVS.

Comment 20

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!