Closed Bug 26420 Opened 25 years ago Closed 25 years ago

Enable |ASSERT_NO_QUERY_NEEDED| for the |getter_AddRefs()| case

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: scc-obsolete, Assigned: scc-obsolete)

Details

When assigning into an |nsCOMPtr| using |=| and the user didn't specify |
do_QueryInterface| or provide another |nsCOMPtr| of the same type, a test is 
performed after the assignment to ensure that no query was actually needed.  But 
there is another way to assign into an |nsCOMPtr|, you can pass it as a `result 
parameter' with |getter_AddRefs()|.  In a debug build, |getter_AddRefs()| should 
perform the same test.

I currently can't enable this test because the assert fires twice for each page 
load.  The underlying bug is that proxies don't correctly support |
QueryInterface|.  <dougt@netscape.com> has code to fix this, when he checks that 
in, the test can be enabled.
Status: NEW → ASSIGNED
Target Milestone: M14
Alright.  <dougt@netscape.com> checked in his fixes that allow me to turn this 
on, so I'm turning it on now.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Marking Verified per eng comment.s
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.