Closed Bug 264231 Opened 15 years ago Closed 6 years ago

SetViewVisibility should respect view update batches

Categories

(Core :: Web Painting, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Unassigned)

References

Details

SetViewVisibility() can currently call Show() or Hide() on widgets in the middle
of an update batch.  That seems wrong.

I tried doing this the simple way -- check for an update batch in
SetViewVisibility() and bail if we're in one, then sync the visibility state
(with nsIWidget::IsVisible) when doing ProcessPendingUpdates.

That doesn't seem to work right, though -- the dropdown widgets of comboboxes
don't end up properly hidden (tested by loading
https://bugzilla.mozilla.org/query.cgi and seeing dark gray rectangles all
over)....  I'm not sure what's up there.
Depends on: 264245
QA Contact: ian → layout.view-rendering
We now do the Show() and Hide() async from bug 851641, so this should be fixed now.
Status: NEW → RESOLVED
Closed: 6 years ago
Depends on: 851641
Resolution: --- → FIXED
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.