264231 - SetViewVisibility should respect view update batches

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Boris Zbarsky [:bzbarsky]]

SetViewVisibility() can currently call Show() or Hide() on widgets in the middle
of an update batch.  That seems wrong.

I tried doing this the simple way -- check for an update batch in
SetViewVisibility() and bail if we're in one, then sync the visibility state
(with nsIWidget::IsVisible) when doing ProcessPendingUpdates.

That doesn't seem to work right, though -- the dropdown widgets of comboboxes
don't end up properly hidden (tested by loading
https://bugzilla.mozilla.org/query.cgi and seeing dark gray rectangles all
over)....  I'm not sure what's up there.

Comment 1

[Timothy Nikkel (:tnikkel)]

We now do the Show() and Hide() async from bug 851641, so this should be fixed now.