264253 - exthandler should get an nsIPrompt off the window context [@ nsExternalAppHandler::Cancel()]

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

this would remove both the dom and the windowwatcher depdendency.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 162002 [details] [diff] [review]
patch

r=bzbarsky

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in uriloader/exthandler/Makefile.in;
/cvsroot/mozilla/uriloader/exthandler/Makefile.in,v  <--  Makefile.in
new revision: 1.54; previous revision: 1.53
done
Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.271; previous revision: 1.270
done

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

so, the last hunk of this patch surely explains all the
nsExternalAppHandler::Cancel crashes from talkback. adding signature to summary.

(not needed on branches, the code there does not have this problem)