264278 - convert line endings in some charset.mk files to Unix native line endings

Status: RESOLVED WORKSFORME

(Mozilla Localizations :: Other, defect)

Description

[Chase Phillips]

Attempting to build the de-DE, hu-HU, and nb-NO localizations from the Aviary
branch fails since iconv is being passed improperly formatted character set
names.  This string is taken from their charset.mk files which includes extra
control characters.  The paths to each of these files are:

  mozilla/toolkit/locales/de-DE/installer/windows/charset.mk
  mozilla/toolkit/locales/hu-HU/installer/windows/charset.mk
  mozilla/toolkit/locales/nb-NO/installer/windows/charset.mk

An example of a working charset.mk can be found at:

  mozilla/toolkit/locales/fi-FI/installer/windows/charset.mk

Viewing the files in 'vi' or 'vim' will show the improperly places ^Ms at the
end of each line.  Each of the non-working files mentioned above should be
updated to use Unix line endings.

Bug 259605 is dependent on this bug.

Comment 1

[Benjamin Smedberg]

Each l10n owner needs to make this change, assigning to the generic watcher
email, ccing owners and peers.

Comment 2

[Axel Hecht]

Fix checked in for de-DE, had that change in my tree. Dang, got approval to land 
this days ago, sorry.

Comment 3

[Håvard Mork]

also fixed nb-NO

Comment 4

[Mikael Hedberg]

Fixed in sv-SE.

Comment 5

[Reed Loden [:reed]]

Is this bug still valid or have all the locales converted from DOS to UNIX line ending formats for mozilla/toolkit/locales/*/installer/windows/charset.mk?

Comment 6

[Axel Hecht [:Pike]]

Seems that this is not that much of an issue anymore, suprisingly. We have
red and green builds among those that have windows line endings.

The current state of the art is

file */toolkit/installer/windows/charset.mk 
ar/toolkit/installer/windows/charset.mk:        ASCII text
be/toolkit/installer/windows/charset.mk:        ASCII text
bg/toolkit/installer/windows/charset.mk:        ASCII text
ca/toolkit/installer/windows/charset.mk:        ASCII text, with CRLF line terminators
cs/toolkit/installer/windows/charset.mk:        ASCII text
da/toolkit/installer/windows/charset.mk:        ASCII text
de/toolkit/installer/windows/charset.mk:        ASCII text
el/toolkit/installer/windows/charset.mk:        ASCII text
en-GB/toolkit/installer/windows/charset.mk:     ASCII text
es-AR/toolkit/installer/windows/charset.mk:     ASCII text
es-ES/toolkit/installer/windows/charset.mk:     ASCII text, with CRLF line terminators
eu/toolkit/installer/windows/charset.mk:        ASCII text
fi/toolkit/installer/windows/charset.mk:        ASCII text, with CRLF line terminators
fr/toolkit/installer/windows/charset.mk:        ASCII text
fy-NL/toolkit/installer/windows/charset.mk:     ASCII text, with CRLF line terminators
ga-IE/toolkit/installer/windows/charset.mk:     ASCII text, with CRLF line terminators
gu-IN/toolkit/installer/windows/charset.mk:     ASCII text
he/toolkit/installer/windows/charset.mk:        ASCII text, with CRLF line terminators
hu/toolkit/installer/windows/charset.mk:        ASCII text
hy-AM/toolkit/installer/windows/charset.mk:     ASCII text
it/toolkit/installer/windows/charset.mk:        ASCII text
ja-JP-mac/toolkit/installer/windows/charset.mk: ASCII text
ja/toolkit/installer/windows/charset.mk:        ASCII text
ko/toolkit/installer/windows/charset.mk:        ASCII text
lt/toolkit/installer/windows/charset.mk:        ASCII text
mk/toolkit/installer/windows/charset.mk:        ASCII text
mn/toolkit/installer/windows/charset.mk:        ASCII text
nb-NO/toolkit/installer/windows/charset.mk:     ASCII text
nl/toolkit/installer/windows/charset.mk:        ASCII text
nn-NO/toolkit/installer/windows/charset.mk:     ASCII text
pa-IN/toolkit/installer/windows/charset.mk:     ASCII text
pl/toolkit/installer/windows/charset.mk:        ASCII text
pt-BR/toolkit/installer/windows/charset.mk:     ASCII text
ro/toolkit/installer/windows/charset.mk:        ASCII text
ru/toolkit/installer/windows/charset.mk:        ASCII text
sk/toolkit/installer/windows/charset.mk:        ASCII text
sl/toolkit/installer/windows/charset.mk:        ASCII text, with no line terminators
sq/toolkit/installer/windows/charset.mk:        ASCII text, with CRLF line terminators
sv-SE/toolkit/installer/windows/charset.mk:     ASCII text
tr/toolkit/installer/windows/charset.mk:        ASCII text
zh-CN/toolkit/installer/windows/charset.mk:     ASCII text
zh-TW/toolkit/installer/windows/charset.mk:     ASCII text

Comment 7

[Axel Hecht [:Pike]]

Seems like this is not something we need to worry about these days, closing WORKSFORME.