264296 - sslsample maybe crashed when provide an invalid client cert

Status: RESOLVED WONTFIX

(NSS :: Tools, defect, P5)

Description

[liupeng]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.0.3705)
Build Identifier: NSS3.9 sslsample

In sslsample server.c function setupSSLSocket,line 260,as follow:
    secStatus = SSL_BadCertHook(sslSocket,
                             (SSLBadCertHandler)myBadCertHandler, &certErr);
    And in sslsample.c function myBadCertHandler line 179,as follow:
    *(PRErrorCode *)arg = err = PORT_GetError();
    I guess when an invalid client cert provide,it will call
myBadCertHandler,and set error to arg.
    But unfortunately,the arg certErr is declared in function
setupSSLSocket,when this function exit,the memoryspace allocate for certErr
was took back by OS.And when myBadCertHandler was called,it will use an
invalid address to set error code.


Reproducible: Sometimes
Steps to Reproduce:
1.
2.
3.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I have filed bug 359302, which requests that the non-exemplary sslsample 
source code be expunged from the NSS source tree.