264324 - incorrect defines in s390/s390x

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041013
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041013

according to one of our s390 developers the s390x platform does define the s390,
too. Therefore I suggest the attached patch to avoid problems.

Reproducible: Always
Steps to Reproduce:
.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: proposed patch

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

wtc: thanks for review. Could you please check this in? It seems NSPR
write-access is rare ;-)

Comment 3

[Jean-Marc Desperrier]

Wolfgang, you should ask for the right to create bug as new, especially for when
you enter bugs for the s390 arch.

If wtc doesn't answer, try to ping some other of the NSPR peers. 
But I too think it will be a bit uneasy to get a patch inside NSPR :-)

Comment 4

[Wan-Teh Chang]

Attachment: Patch as checked in

This is what I actually checked in.  I simply
test for __s390x__ before __s390__.  Just a
matter of personal preference.

Comment 5

[Wan-Teh Chang]

I checked in the patch on the NSPR trunk (NSPR 4.6)
and NSPRPUB_PRE_4_2_CLIENT_BRANCH (post Mozilla 1.8
Alpha 4).

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

thanks, that looks nicer ;-)

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 162522 [details] [diff] [review]
Patch as checked in

Want this on the branches for the distributors that care about s390(x).

Comment 8

[Mike Shaver (:shaver emeritus)]

Comment on attachment 162522 [details] [diff] [review]
Patch as checked in

a=shaver for our branchen.