264349 - No keyboard shortcut for Highlight on Find toolbar

Status: RESOLVED DUPLICATE of bug 280159

(Firefox :: Keyboard Navigation, defect, P3)

Description

[Ger Teunis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041013 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041013 Firefox/0.10

All buttons on the find toolbar have keyboard shortcuts (find next, find
previous, find criteria), except the highlight button. Can't use the highlight
function when using keyboard.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Marc Randolph]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050122 Firefox/1.0+


WFM on 1.1 Trunk by using <ctrl-enter>

Comment 2

[Ger Teunis]

(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050122
Firefox/1.0+
> 
> 
> WFM on 1.1 Trunk by using <ctrl-enter>

That doesn't work with FAYT searches (it will follow links if one is selected).
For search is works like a charm.

Comment 3

[Aaron Leventhal]

Ctrl+Enter is not discoverable -- might as well not have the shortcut at all,
except for the .5% of people who know about it.

I suggest renaming it Highlight all and underlining the a as a mnemonic.
That would be more consistent with Mat_c_h case which is next to it.

So, 3 advantages to Alt+A:
- Discoverable
- Works with find as you type that was started with /
- Consistent with Match case

Comment 4

[lucas]

ctrl + enter doesnt work in the 1.0.2 build for OS X on a powerbook; hover tag
lists ctrl + enter shortcut

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 310147 has been marked as a duplicate of this bug. ***

Comment 6

[Wayne Mery (:wsmwk)]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051107 Firefox/1.5(In reply to comment #3)
> Ctrl+Enter is not discoverable -- might as well not have the shortcut at all,
> except for the .5% of people who know about it.
> 
> I suggest renaming it Highlight all and underlining the a as a mnemonic.

sounds logical, and this is on trunk and in FF 1.5.
so is this bug wontfix?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Fixed by bug 280159.

*** This bug has been marked as a duplicate of 280159 ***