264397 - Sunbird - Preferences: "General" icon is always highlighted (highlit?)

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[Matthew (lilmatt) Willis]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913 Firefox/0.10.1

Sunbird 0.2a, Mac OS X 10.3.5

Go to "Sunbird" > "Preferences"
In the preferences "sheet" that comes down, "General" is selected and has a dark
blue background. Select any other option (for example: "Alarms"). "General"
changes to light blue, as if you were moused over it. You can't make it change
to white (which is what it should be when it's not selected or moused over) no
matter what you do.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Matthew (lilmatt) Willis]

May be related to bug 256129 
May not.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev0 - trunk - changes icons from FF to Sunbird icons

This file replaces the one at
mozilla/calendar/sunbird/themes/pinstripe/sunbird/pref/Options.png

Comment 3

[Matthew (lilmatt) Willis]

Attachment: rev0 - trunk - enables pinstripe themed pref panel for Mac OS X

This enables the pinstripe themed pref panel for Mac OS X, eliminating the bug.

It requires attachment 164772 [details]

Comment 4

[Mostafa Hosseini]

Comment on attachment 164774 [details] [diff] [review]
rev0 - trunk - enables pinstripe themed pref panel for Mac OS X

First part has been checked in although we won't enable pinstripe for now as
discussed in irc

Comment 5

[Mostafa Hosseini]

Comment on attachment 164772 [details]
rev0 - trunk - changes icons from FF to Sunbird icons

The image can be checked in though

Comment 6

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - instead of enabling pinstripe, adds ifdefs to winstripe css

Please check in attachment 164772 [details] as
mozilla/calendar/sunbird/themes/winstripe/pref/OptionsMac.png
to match this patch.

Comment 7

[Matthew (lilmatt) Willis]

Forgot to mention:
The calendarManager.js lines enable the throbber to actually do something...
namely rotate when refreshing a remote calendar

Comment 8

[Mostafa Hosseini]

I didn't expect this much change. It makes the pinstripe-over-winstripe method
proposed in attachment 164774 [details] [diff] [review] look like a better approach. I would like to hear
mvl's opinion too.

Comment 9

[Matthew (lilmatt) Willis]

Attachment: rev2 - trunk - removes ifdefs per discussion in IRC

Attachment 164772 [details] needs to be checked in as 
mozilla/calendar/sunbird/themes/pinstripe/sunbird/pref/Options.png
to coorespond with this patch

Comment 10

[Matthew (lilmatt) Willis]

Attachment: None of this matters if the throbber doesn't do anything. This makes it do something.

This patch makes the throbber throb when refreshing remote calendars.

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

>Index: winstripe/sunbird/jar.mn
> +       skin/classic/calendar/calendar.css
>+        skin/classic/calendar/mainCalendar.css                      (calendar.css)

I'm a bit confused. You want the calendar.css under a different name to be
available from pinstripe. But this file won't be build if you flip the switch to
use pinstripe. (and without that switch, the pinstripe files won't be build, so
the rest of this patch has no effect)

> -DIRS = winstripe
> +DIRS = winstripe pinstripe

hmm, so it will be build.
I would like it better if you used relative dirs in the pinstripe jar.mn file,
to include the winstripe files (maybe under a different name)
that way, winstripe won't have one file twice.

Comment 12

[Matthew (lilmatt) Willis]

Attachment: rev2 - without whitespace

Comment 13

[Matthew (lilmatt) Willis]

Attachment: rev3 - trunk - patch addresses mvl's comments

Comment 14

[Matthew (lilmatt) Willis]

Attachment: rev3 patch with -w -- no whitespace

Comment 15

[Matthew (lilmatt) Willis]

Attachment: rev4 - trunk - fixes URL typo

Comment 16

[Matthew (lilmatt) Willis]

Attachment: rev4 -w version

So, all three patches should be checked in, and attachment 164772 [details] should be
checked in as
mozilla/calendar/sunbird/themes/pinstripe/sunbird/pref/Options.png

Comment 17

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 165193 [details] [diff] [review]
rev4 -w version

Please add a comment in the makefile.in what trick we are using

Why are you indenting the license blocks with one space?

Wouldn't the reload button changes be part of another bug?

(no need for a new -w patch)

Note that i can't test this patch, due to the lack of a mac.

Comment 18

[Matthew (lilmatt) Willis]

(In reply to comment #17)
> (From update of attachment 165193 [details] [diff] [review])
> Please add a comment in the makefile.in what trick we are using
Ok.

> Why are you indenting the license blocks with one space?
It was how one of them was and it made the stuff line up. I can remove that if
you'd like.
 
> Wouldn't the reload button changes be part of another bug?
Yes, I was just trying to be efficient/lazy. :)

> Note that i can't test this patch, due to the lack of a mac.
I'm rebuilding from scratch with it now to make darn sure that it's ok.

Comment 19

[Matthew (lilmatt) Willis]

Attachment: rev5 - trunk - addresses mvl's comments

Comment 20

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 165204 [details] [diff] [review]
rev5 - trunk - addresses mvl's comments

next time, i think it would be a good idea to split the patches into cleanup
and stuff for other bugs. better for cvs blame :)

Comment 21

[Matthew (lilmatt) Willis]

Comment on attachment 165180 [details] [diff] [review]
None of this matters if the throbber doesn't do anything. This makes it do something.

This attachment moved to bug 268602

Comment 22

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.

Comment 23

[Mostafa Hosseini]

pinstripe/sunbird/jar.mn obviously has problems. calendar.css is not in there
but is being added to the jar file. This is what I get when I build sunbird on mac:

file not found: ./skin/classic/calendar/calendar.css at
../../../../../config/make-jars.pl line 391, <STDIN> line 5.

also I will ask the question in comment #11 again: Why use a different filename
(mainCalendar.css)? 

This is the change that caused this:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/calendar/sunbird/themes/pinstripe/sunbird&command=DIFF_FRAMESET&file=jar.mn&rev1=1.2&rev2=1.3&root=/cvsroot

Comment 24

[Matthew (lilmatt) Willis]

(In reply to comment #23)
> pinstripe/sunbird/jar.mn obviously has problems. calendar.css is not in there
> but is being added to the jar file. This is what I get when I build sunbird on
mac:
> 
> file not found: ./skin/classic/calendar/calendar.css at
> ../../../../../config/make-jars.pl line 391, <STDIN> line 5.
> 
> also I will ask the question in comment #11 again: Why use a different filename
> (mainCalendar.css)? 

This was an attempt to not have two full versions of calendar.css floating
around: a winstripe and a pinstripe one. pinstripe's calendar.css would @import
the winstripe one, but since pinstripe's calendar.css overrides winstripe's
(which it has to do), winstripe's calendar.css had to be available under a
different filename: mainCalendar.css.

That being said, I have an error associated with the above setup, and am
beginning to feel that we should just suck it up and have the two css files,
being careful to put edits in both, and bag the @import nonsense, as it seems
more trouble than it's worth.

Comment 25

[Matthew (lilmatt) Willis]

Attachment: rev6 - fixes jar.mn & removes @import from pinstripe's calendar.css - it is now an independent file

Comment 26

[Mostafa Hosseini]

Comment on attachment 165433 [details] [diff] [review]
rev6 - fixes jar.mn & removes @import from pinstripe's calendar.css - it is now an independent file

calendar.css checked in. Thanks
(The jar.mn patch is incorrect but I've fixed that already )

Comment 27

[Michiel van Leeuwen (email: mvl+moz@)]

I would have liked to try with an absolute path. /calendar/sunbird/themes/... 
Maintaining two almost identical files is really no fun. It will go wrong.

Comment 28

[Mostafa Hosseini]

Well, eventually ( and hopefully ), we'll have a pinstripe theme that would need
its own calendar.css anyway. Meanwhile I guess lilmatt is in charge of the clone :)

Comment 29

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!