264413 - Blocking popups that are not bad.

Status: RESOLVED DUPLICATE of bug 272389

(Camino Graveyard :: General, defect)

Description

[Thom McVeigh]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041013 Camino/0.8+
Build Identifier: Camino 2004101308 (v0.8+)

Javascript bookmarks like the blogger 'blog this' are unable to create windows
due to pop up blocking. 

Reproducible: Always
Steps to Reproduce:
1.Click the link I gave

Actual Results:  
Pop up blocking icon appears in bottom left corner of browser

Expected Results:  
A window should have popped up, after all it wasn't the site requesting it, it
was me.

Comment 1

[Thom McVeigh]

Just noticed after clicking on the URL link right above, that it works as
desired when clicked on a page. Drag the URL to your bookmark bar, and it ceases
to function as desired. 

Comment 2

[Mike Pinkerton (not reading bugmail)]

i imagine this fails with ff too, right?

Comment 3

[Thom McVeigh]

(In reply to comment #2)
> i imagine this fails with ff too, right?

Works for me under Firefox 0.10 

Comment 4

[Mick Fox]

Confirming with Camino 2004101608 using 10.3.5.
It didn't work using a bookmark or in the location bar.

The popup icon shown says the popup is from the current page and gives me the
option to unblock bugzilla.mozilla.org.

Comment 5

[Jasper]

Confirmed using 2004101408 (v0.8+) NB on 10.3.5

Apperently we are doing something to much. I'm going to look into our popup prefs.

Comment 6

[Jasper]

Ok this is the info I have now. Our current popup block implementation is very
naive compared to the FF settings.

Camino popup prefs:
dom.disable_open_during_load -> true

Firefox uses:
dom.popup_allowed_events -> change click dblclick mouseup reset submit
dom.popup_maximum -> 20
privacy.popups.firstTime -> false
privacy.popups.policy -> 1
privacy.popups.usecustom -> true

Comment 7

[Jasper]

Ok some more info.

if you open a blank new window that doesn't have any page loaded yet, the
javascript popup works from the bm toolbar. But as soon as a page is loaded
Camino blocks the popup.

Comment 8

[Mike Pinkerton (not reading bugmail)]

i have a fix for this over in 272389. it was a regression from the popup blocker
rewrite jst did.

*** This bug has been marked as a duplicate of 272389 ***