264439 - unable to display themes/extensions for "all" platforms

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[sairuh (rarely reading bugmail)]

I'm unable to display themes/extensions for all platforms at u.m.o. this occurs
on all platforms, but this issue is particularly bad when using a Mac (eg,
testing with firefox 2004101406-0.9+ on OS X 10.3.5).

0. on http://update.mozilla.org/ the page notes that there are 48 Firefox themes.

1. go http://update.mozilla.org/themes/showlist.php?category=All (clicking the
"All" link on the left side of many u.m.o. pages will take you there).

note that (when using a Mac), there are only 3 themes provided, labeled
specifically to work with Macs.

2. change the OS: dropmenu near the top of the page to "ALL" and click the
"Update" button.

expected: should get a listing of all themes which are applicable to "All OSes."

actual results: the dropmenu resets to "MacOSX" and only the 3 themes are
displayed. similar results also occur for extensions. and also similar results
when using Linux (resulting in the OS being reset to Linux, etc.).

I can work my way around this issue by going to
http://update.mozilla.org/themes/ and clicking on a given theme's link --but
this is only useful for themes which happen to be listed on that page. this
still doesn't allow me to (easily) see all themes which are "all OS" compatible.

Comment 1

[sairuh (rarely reading bugmail)]

marcia showed me a funky workaround: select "Windows" from the "OS" list, hit
"Update" --and 48 themes are then listed.

Comment 2

[Wolf [:wolf]]

Might be browser detection, what was the User Agent(s) for the browser(s) having
issues?

Comment 3

[sairuh (rarely reading bugmail)]

for the linux ffox build:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041014 Firefox/0.10

mac coming up...

Comment 4

[sairuh (rarely reading bugmail)]

for Mac firefox:

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041014
Firefox/0.10

Comment 5

[Wolf [:wolf]]

Looks like "All" just fails to actually work. (All is actually just
Cross-Platform not Cross-Platform + All Platform-specific extensions, though).
Not sure why yet, it just returns back to the last-selected OS. (This bug also
appears for update-beta. :-/ ) Doubt it's browser detection at this point
though, since "All" doesn't use it, as it's skipped since you're telling it what
to show you. Marcia's workaround should work fine for now, though it is pretty
funky. heh.

MacOSX is limited from seeing the X-P extensions, because of the fix for Bug
252294. So that's why Linux/Windows see 48, where Mac gets 3. It really is a
nasty hack, but my understanding was X-P themes were causing breakage for Mac
users as a result. If that change needs to be reversed before the root bug of
Bug 222654 (which I've requested blocking-aviary1.0mac status on) is fixed, then
bug 252294 needs to get reopened.

Comment 6

[Wolf [:wolf]]

Attachment: Add "All" to OS Check

As it turns out, "All" was being killed because of the sessionconfig.php OS
check. It thought it was an unknown (and possibly malicious) setting. Oops.
This adds it to the check, so it will be passed through and let the option work
as intended.

Comment 7

[Wolf [:wolf]]

Fixed checked in, branch and trunk. and applied to update and update-beta.