264453 - Remove member variable nsLineLayout::mPresContext

Status: RESOLVED WONTFIX

(Core :: Layout: Block and Inline, defect)

Description

[rbs]

The member variable nsLineLayout::mPresContext can be removed because it can
recovered at all the places where it is used.

Comment 1

[Vidar Haarr (not reading bugmail)]

Attachment: removes the mPresContext member variable

This sorely needs a review :)
I've compiled and tested slashdot.org, etc, but I'm not at all sure I'm using
the right prescontext references.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I guess I'm not quite sure why we want to change this.  nsLineLayout objects are
generally allocated on the stack, and they're always temporary, so it's rather
like caching the result of GetPresContext() (which involves three dereferences)
at the beginning of a function so it can be used a few times.

Comment 3

[rbs]

I am having second thoughts following dbaron's comment above.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Someone feels like wontfixing, then?

Comment 5

[leo]

I suggest this bug is WONTFIXed or at least have "good first bug" removed, if there is a uncertainty about if it should be fixed.

Comment 6

[Dirkjan Ochtman (:djc)]

Resolving as WONTFIX per apparent consensus; feel free to reopen.