264477 - Use proper minus character for XML document tree display

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Luke Deller]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT5.0; en-GB; 1.7.2; DontTellStGeorgeInternetBankingSiteThatImRunningGentooLinux) Gecko/20040831
Build Identifier: Mozilla/5.0 (Windows; U; WinNT5.0; en-GB; 1.7.2; DontTellStGeorgeInternetBankingSiteThatImRunningGentooLinux) Gecko/20040831

An XML file without style information is displayed by showing the document tree.
 Next to most XML elements, there is a plus or a minus to control
expanding/collapsing the children of that element.  Unfortunately it uses an
ASCII hyphen character rather than a proper minus character (− a.k.a
−), so the minus looks much narrower than the plus.

Reproducible: Always
Steps to Reproduce:
1.Open an XML document in mozilla which doesn't have style information (see URL
for an example)
2.Collapse one of the elements by clicking on the "-" to its left


Actual Results:  
Note that the "+" is much wider than the "-"

Expected Results:  
The minus character should match the plus character in width.

Comment 1

[Stefan Borggraefe]

I agree, this looks much better.

Comment 2

[Stefan Borggraefe]

Attachment: Patch

Comment 3

[Stefan Borggraefe]

Comment on attachment 162177 [details] [diff] [review]
Patch

bz: I saw you did some reviews for these files in the past. Can you do this
one, too? Thanks! :-)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 162177 [details] [diff] [review]
Patch

This needs OK from sicking.  Also, how common is this character in fonts?  That
is, what's the chance that we'll actually get worse rendering?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 162177 [details] [diff] [review]
Patch

r=me if the issue bz brought up isn't a problem. This goes both for the default
font, and the font you get if you choose view->Use Style->monospace. In other
words, how common is this character in monospace fonts?

Comment 6

[Uri Bernstein]

If comment #4 is a real issue, a possible alternative solution would be to use a
monospaced font (where the ASCII minus has the same width as the plus) for the
pluses and minuses only, in the default style (still using a proportional font
for everything else).

Comment 7

[Luke Deller]

Re comment #4, if the minus character is not available, then mozilla falls back
to using the ASCII hyphen (see bug 232931), so we'd be no worse off than before.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

have you actually tested this? Or is this just how it should work?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 162177 [details] [diff] [review]
Patch

Luke's right.  The minus char is one of the ones we do fallback for; I totally
forgot that.  sr=me.

Comment 10

[Stefan Borggraefe]

Fix checked in.