264498 - target "installers-ab-CD" in browser/locales/Makefile.in does not work right on MacOS X

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Martin Creutziger [:MMx]]

I found another bug in the Makefile.in that prevents the creation of localized
Firefox builds for MacOS X. 
Problem is:
Windows and Linux package from dist/bin/, but MacOS packages dist/Firefox.app.
This directory does not get updated for the different locales.

Steps we need:
1. clean dist/firefox/, this gets recreated when calling "make -C browser/installer"
2. clean dist/Firefox.app/Contents/MacOS/chrome/
3. clean dist/Firefox.app/Contents/MacOS/searchplugins/
4. remove dist/Firefox.app/Contents/MacOS/defaults/firefox.js

then, after building the new jars, sync the dirs/files of steps 2-4 with the
according dirs/files in dist/bin

That should be it - I'll attach a patch for review after I tested it.

Comment 1

[Martin Creutziger [:MMx]]

P.S.: see the logs of maya tinderbox - no matter what language it builds, always
en-US is packaged.

P.P.S.: sorry for the bugspam

Comment 2

[Martin Creutziger [:MMx]]

Attachment: updated browser/locales/Makefile.in

This updated Makefile.in includes the patch of bug 257463.

bsmedberg, should I create a seperate patch or one that does include the one
for bug 257463?

Comment 3

[Martin Creutziger [:MMx]]

This should be fixed now with the patch of bug 257463.

I tested it on my machine and it works fine, lets see how the official nighties
turn out.