Closed
Bug 264537
Opened 20 years ago
Closed 19 years ago
Firefox startup dumps random text to console
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8rc1
People
(Reporter: bzbarsky, Assigned: nthomas)
Details
(Keywords: fixed1.8)
Attachments
(2 files)
1.99 KB,
text/plain
|
Details | |
4.76 KB,
patch
|
robert.strong.bugs
:
review+
darin.moz
:
superreview+
asa
:
approval1.8rc1+
|
Details | Diff | Splinter Review |
BUILD: 0.10.1 or 2004-10-14-21 branch Firefox nightly on Linux. STEPS TO REPRODUCE: 1) Make sure you have no firefox profile 2) Start Firefox 3) Select any option in the import dialog (well, I tried "don't import anything" and importing NS4 and Mozilla 1.x profiles). ACTUAL RESULTS: xterm where you started Firefox shows: *** nsExtensionManager::_disableObsoleteExtensions - failure, catching exception so finalize window can close *** loading the extensions datasource *** loading the extensions datasource In addition, when importing the SeaMonkey profile, it shows: *** started *** before 1 *** after 16 *** before 64 *** after 64 *** before 32 *** after 32 *** done during the import itself. EXPECTED RESULTS: Don't output debug information to console in a release build.
Reporter | ||
Updated•20 years ago
|
Version: Trunk → 1.0 Branch
Reporter | ||
Comment 1•20 years ago
|
||
Note that these are dump() statements. I have no idea why they are getting dumped. My Mozilla profile does have dump enabled, but that should not affect the "no import" or "import from NS4" cases.
Assignee | ||
Comment 2•19 years ago
|
||
There is quite alot more console output in 1.5b2, with the Extension Manager printing 12 lines the first time a new profile is used, and at least 8 lines on each check for extension updates. (I modified <firefox install>/ components/ nsExtensionManager.js#480 so that dump uses ***nsExtensionManager*** to prefix instead of ***, uniquely identifying the source of the messages). Patch for this, and the migration dump()'s, coming up.
Assignee | ||
Updated•19 years ago
|
Flags: blocking1.8rc1?
Assignee | ||
Comment 3•19 years ago
|
||
This patch uses the variable gLoggingEnabled for all Extension Manager messages rather just the single case. It relies on the default value for the preference extensions.logging.enabled being set to false in firefox/thunderbird.js, which is currently the case, and therefore only affects new profiles. I tried to suppress dump() using browser.dom.window.dump.enabled, but the Extension Manager does not seem to have access to the preferences from the profile it is manipulating.
Updated•19 years ago
|
Flags: blocking1.8rc1? → blocking1.8rc1-
Updated•19 years ago
|
Attachment #199663 -
Flags: review?(robert.bugzilla)
Assignee | ||
Comment 4•19 years ago
|
||
A correction to my previous comment, this patch works for all profiles because the default pref applies unless the profile overrides.
Comment 5•19 years ago
|
||
Comment on attachment 199663 [details] [diff] [review] Leverage the default pref for extensions.logging.enable Sorry it took so long to get to this - looks good.
Attachment #199663 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Comment 6•19 years ago
|
||
Is superreview required ? If not, could Rob or Benjamin land this on the trunk in preparation for asking for approval1.8rc1+.
Comment 7•19 years ago
|
||
Comment on attachment 199663 [details] [diff] [review] Leverage the default pref for extensions.logging.enable Looks good to me too. I think we should definitely take this for 1.5 as it makes our Linux build look extremely unpolished when run from the command line.
Attachment #199663 -
Flags: superreview+
Attachment #199663 -
Flags: approval1.8rc1?
Updated•19 years ago
|
Assignee: bugs → nrthomas
OS: Linux → All
QA Contact: bugs → extension.manager
Hardware: PC → All
Version: 1.0 Branch → 1.5 Branch
Updated•19 years ago
|
Attachment #199663 -
Flags: approval1.8rc1? → approval1.8rc1+
Comment 8•19 years ago
|
||
The second hunk of this patch removes a check for gLoggingEnabled. Is that because the check is unnecessary in that page?
Comment 9•19 years ago
|
||
It isn't necessary since gLoggingEnabled has been added to the LOG function function LOG(string) { - dump("*** " + string + "\n"); + if (gLoggingEnabled) + dump("*** " + string + "\n"); gConsole.logStringMessage(string); }
Comment 10•19 years ago
|
||
This is fixed on trunk and the 1.8 branch.
Updated•19 years ago
|
Target Milestone: --- → Firefox1.5rc1
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•