nsInstall::GetWinProfile() and a few other methods store an int in a jsval directly w/o making sure it's flagged as an int, and shifted properly etc. The code needs to use INT_TO_JSVAL(). This makes errors from those methods come out to the installer JS code with the wrong value. Patch coming up.
Created attachment 162216 [details] [diff] [review] Use INT_TO_JSVAL() when storing ints in jsvals. Ahem, this is the version I was trying to attach here.
Attachment #162214 - Attachment is obsolete: true
Comment on attachment 162222 [details] [diff] [review] So maybe like this then? yup, that'll do it. r/sr=dveditz
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Probably want this on the aviary/1.7 branches, right?
Either way is fine with me, doesn't seem like a lot of people are running into this, so I can deal w/o it on the branches.
You need to log in before you can comment on or make changes to this bug.