Form control with name="action" confuses "Add a keyword to this search"

RESOLVED FIXED in Firefox1.5

Status

()

defect
P3
minor
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: mozilla, Assigned: philor)

Tracking

Trunk
Firefox1.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 obsolete attachments)

(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

http://host:8080/?search=[formfield]

If you click on that form element in a page, and add it as a search, the
bookmark ends up:

http://host:8080/%5Bobject%20HTMLInputElement%5D?search=%s

When you use it, you get a 404 message on that page

Reproducible: Always
Steps to Reproduce:
1. Create search form in index.html
2. Go to site w/o specifying page (http://host/) .. implies index.html
3. Right moouse click field and "Add a keyword for this search"
4. URL in Bookmark will now be
http://host/%5Bobject%20HTMLInputElement%5D?search=%s 

Actual Results:  
The search will attempt to load that page, with %s substitution.  The server
will respond and log a 404 message for "object HTMLInputElment" page not found.

Expected Results:  
object HTMLInputElement should not be in the URL.  removing it from the bookmark
produces correct functionality.

I am using GrayModern 0.6 theme.

Extensions Installed:

 Mouse Gestures 1.0
 ieview 0.83
 freetranslate 0.02
 Scribe 0.21
 Translate Page 0.1
 Wikalong 0.12
 DictionarySearch 0.6.3
 Wayback 0.1
 McSearchPreview 1.4.1
(Assignee)

Comment 1

15 years ago
Unable to reproduce: http://philringnalda.com/mtests/searchme/ is my best guess
at testcasing what you are saying, and that just gives me a bookmark URL of
http://philringnalda.com/mtests/searchme/?search=%s

Can you reproduce this with all your extensions disabled? If so, what HTML are
you using?
(Reporter)

Comment 2

15 years ago
I isolated down some sample code and found out the true issue.  It's not related
to no index.html defined, it's a hidden form element:

-- snip --
<FORM method="get" action="" id="search" class="submenu">
<FONT SIZE="1"><B>Search:</B></FONT>
<INPUT ALIGN="right" TYPE="hidden" NAME="action" VALUE="node_search">
<input size="10" name="search_node" class="field">&nbsp;&nbsp;</TD>
</FORM>
-- snip --

If you remove the TYPE="hidden" input, invalid url does not happen.
Summary: No file in URL does not work when used to "Add a keyword to this search" → Hidden field in form corrupts "Add a keyword to this search"
(Assignee)

Comment 3

15 years ago
Ah, that's actually a different problem yet: it doesn't matter whether it's
hidden or not, or an input or not: any form control with name="action" will
throw off selecting the action attribute of the form.

bug 122128 comment 3 explains why and how to get around it
(form.getAttribute("action") rather than form.action) in the context of Page
Info - I'd guess that AddKeywordForSearchField just needs to do the same, use
node.form.getAttribute("action") instead of node.form.action.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Hidden field in form corrupts "Add a keyword to this search" → Form control with name="action" confuses "Add a keyword to this search"
(Assignee)

Updated

15 years ago
Assignee: p_ch → vladimir
Component: Search → Bookmarks
QA Contact: firefox.search → mconnor
(Assignee)

Comment 4

15 years ago
(Assignee)

Updated

15 years ago
Attachment #162724 - Flags: review?(vladimir)
Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

r=vladimir
Attachment #162724 - Flags: review?(vladimir)
Attachment #162724 - Flags: review+
Attachment #162724 - Flags: approval-aviary?

Comment 6

15 years ago
Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

a=asa for aviary checkin.
Attachment #162724 - Flags: approval-aviary? → approval-aviary+
Whiteboard: [have patch] - ready to land

Comment 7

15 years ago
Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

need re-approval now that we're past 1.0 RC. setting back to request.
Attachment #162724 - Flags: approval-aviary+ → approval-aviary?

Comment 8

15 years ago
Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

a=asa for aviary checkin.
Attachment #162724 - Flags: approval-aviary? → approval-aviary+
Assignee: vladimir → vladimir+bm
Posted patch Updated patch (obsolete) — Splinter Review
Carrying over review, requesting approval for a simple fix that's been hanging
around forever.
Attachment #162724 - Attachment is obsolete: true
Attachment #186268 - Flags: review+
Attachment #186268 - Flags: approval-aviary1.1a2?
OS: Windows 2000 → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → Firefox1.1
Version: unspecified → Trunk

Updated

14 years ago
Attachment #186268 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Whiteboard: [have patch] - ready to land → [checkin needed][a+]

Comment 10

14 years ago
Comment on attachment 186268 [details] [diff] [review]
Updated patch

mozilla/browser/base/content/browser.js 	1.437
Attachment #186268 - Attachment is obsolete: true

Updated

14 years ago
Assignee: vladimir+bm → bugzilla
Whiteboard: [checkin needed][a+]
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.