264607 - Form control with name="action" confuses "Add a keyword to this search"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Mylo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

http://host:8080/?search=[formfield]

If you click on that form element in a page, and add it as a search, the
bookmark ends up:

http://host:8080/%5Bobject%20HTMLInputElement%5D?search=%s

When you use it, you get a 404 message on that page

Reproducible: Always
Steps to Reproduce:
1. Create search form in index.html
2. Go to site w/o specifying page (http://host/) .. implies index.html
3. Right moouse click field and "Add a keyword for this search"
4. URL in Bookmark will now be
http://host/%5Bobject%20HTMLInputElement%5D?search=%s 

Actual Results:  
The search will attempt to load that page, with %s substitution.  The server
will respond and log a 404 message for "object HTMLInputElment" page not found.

Expected Results:  
object HTMLInputElement should not be in the URL.  removing it from the bookmark
produces correct functionality.

I am using GrayModern 0.6 theme.

Extensions Installed:

 Mouse Gestures 1.0
 ieview 0.83
 freetranslate 0.02
 Scribe 0.21
 Translate Page 0.1
 Wikalong 0.12
 DictionarySearch 0.6.3
 Wayback 0.1
 McSearchPreview 1.4.1

Comment 1

[Phil Ringnalda (:philor)]

Unable to reproduce: http://philringnalda.com/mtests/searchme/ is my best guess
at testcasing what you are saying, and that just gives me a bookmark URL of
http://philringnalda.com/mtests/searchme/?search=%s

Can you reproduce this with all your extensions disabled? If so, what HTML are
you using?

Comment 2

[Mylo]

I isolated down some sample code and found out the true issue.  It's not related
to no index.html defined, it's a hidden form element:

-- snip --
<FORM method="get" action="" id="search" class="submenu">
<FONT SIZE="1"><B>Search:</B></FONT>
<INPUT ALIGN="right" TYPE="hidden" NAME="action" VALUE="node_search">
<input size="10" name="search_node" class="field">&nbsp;&nbsp;</TD>
</FORM>
-- snip --

If you remove the TYPE="hidden" input, invalid url does not happen.

Comment 3

[Phil Ringnalda (:philor)]

Ah, that's actually a different problem yet: it doesn't matter whether it's
hidden or not, or an input or not: any form control with name="action" will
throw off selecting the action attribute of the form.

bug 122128 comment 3 explains why and how to get around it
(form.getAttribute("action") rather than form.action) in the context of Page
Info - I'd guess that AddKeywordForSearchField just needs to do the same, use
node.form.getAttribute("action") instead of node.form.action.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: getAttribute instead of .action

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

r=vladimir

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

a=asa for aviary checkin.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

need re-approval now that we're past 1.0 RC. setting back to request.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 162724 [details] [diff] [review]
getAttribute instead of .action

a=asa for aviary checkin.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: Updated patch

Carrying over review, requesting approval for a simple fix that's been hanging
around forever.

Comment 10

[timeless]

Comment on attachment 186268 [details] [diff] [review]
Updated patch

mozilla/browser/base/content/browser.js 	1.437

Comment 11

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change