264622 - 'Tabbed browsing' options for 'Force links...' to open in a new tab breaks certain bookmarklet types.

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Rowne-Wuff Mastaile]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041011 Plushbadger/1.0 X (Firefox/0.10.1 [Moox-M1 Nightlies] polymorph)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041011 Plushbadger/1.0 X (Firefox/0.10.1 [Nightlies] polymorph)

First of all, I did try searching for this as 'tab breaks bookmarklet' but I
couldn't find anything, which surprises me really as I'd think that bookmarklets
would still be in use.  If however I've somehow missed the bug, my apologies.

Anyway, I've tried this with a fresh profile and it seems a constant.  If it
helps I'm using an official zipped build off the FTP servers.

Using the URL noted in this bug, I added the 'Edit Styles' bookmarklet, now if
the 'Force links that open in new windows to open in:' option isn't checked, it
works perfectly, popping up in a new tab with all the relevant CSS information.

If however 'Force links...' is checked and 'a new tab' is selected, clicking the
'Edit Styles' link on the site or even my bookmarklet breaks.  What I get is a
new tab which is completely blank, it's an edit field but all the information
that should be there, isn't and no changes I make there are applied to the other
tab.

It looks like opening in a tab denies it document.write() or somesuch.

I'm very new to Javascript though and you fellows are the experts, all that I
know is that I can reproduce it every time, it's not a big problem really but I
figured that if this one slipped past 1.0Final, a lot of people might notice and
this is one of those things certain groups might bitch over.

"Sure Firefox has a flat-tabbed interface but it breaks bookmarklets!"

Bah.

It might even just be my end though for all I know but I hope not, considering I
tried a new profile for it.

Reproducible: Always
Steps to Reproduce:
1. Drag the bookmarklet from the page into the bar.
2. Set the browser to open all window links in new tabs.
3. Click the bookmarklet on any page that has CSS embedded in any way.

Actual Results:  
Blank tab or correct window, respectively.

Expected Results:  
The information should've been carried over to the new tab, as it is with the
new window.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041017 Firefox/1.0

WFM

Comment 2

[Rowne-Wuff Mastaile]

(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041017
Firefox/1.0
> 
> WFM
> 

Informative...

It might've been fixed in a build after 1011 though so I'll have to try that
soon, did you try clicking the link from the site?  What are your tab options? 
Tabbrowser Preferences /fixes/ this (as it uses different code), do you have
that installed?  I'll create a mockup page as an example soon but Squarefree
should do.  If it's set so that javascript links open in a tab (all javascript
links, including those that would otherwise resize), it loses its ability to
document.write(), as far as I can see.  I'll try the latest available build in a
bit.

Comment 3

[Dan M]

WFM as well with an Aviary branch build from this morning. This quote:

>if the 'Force links that open in new windows to open in:' option isn't
>checked, it works perfectly, popping up in a new tab with all
>the relevant CSS information.

makes me suspect that you're experiencing interference from your extensions,
since the Edit Styles window won't open into a new tab at all with "Force links
that open in new windows to open in a new tab" not selected. That is what you
meant by that curiously truncated description, yes?

If you've simply reported a bug in one of your extensions, I'm going to be cranky.

Comment 4

[Rowne-Wuff Mastaile]

(In reply to comment #3)
> WFM as well with an Aviary branch build from this morning. This quote:
> 
> >if the 'Force links that open in new windows to open in:' option isn't
> >checked, it works perfectly, popping up in a new tab with all
> >the relevant CSS information.
> 
> makes me suspect that you're experiencing interference from your extensions,
> since the Edit Styles window won't open into a new tab at all with "Force links
> that open in new windows to open in a new tab" not selected. That is what you
> meant by that curiously truncated description, yes?
> 
> If you've simply reported a bug in one of your extensions, I'm going to be cranky.

I do believe I stated that I tried a new profile.

No, I'm not talking about 'one of my extensions', I should've thought it was
obvious since I'd mentioned a fresh profile and explicitly noted Firefox options
by name that I was talking about the Firefox Options dialog, I just didn't want
to patronize anyone by saying "Hey, I'm talking about the Firefox options
dialog, if you hadn't guessed!"

After all, I made sure I wrote the options word-for-word as to avoid any
possible confusion that may have arisen from it, I guess that wasn't enough...

So I shall stress for the record that I'm talking about the Firefox Options
dialog and the tab control options that can be found nestled under Tabbed
Browsing in the Advanced section.

Oh and I can't be experiencing interference from 'my extensions' as I've already
stressed, I was using a fresh profile, which results in no extensions being
present.  I actually tried renaming the Mozilla directory to Moz.tmp to to make
sure there were no residual elements from any previous profiles.

This was with the equivalent of a fresh install of the 20041011 build.

Oh and my description wasn't truncated at all but I do believe that what you
read of it was as you've stressed exactly the opposite of what I said, I stated
that with the option to open new windows into tabs checked (not unchecked), I
did indeed have the bookmarklet open into a tab but the tab was blank and didn't
contain the contents it was supposed to, it opened a blank tab.

Whereas if the options regarding opening in new tabs were left unchecked, it
would open into a new window containing the contents that it was supposed to
contain.

I can also verify that it seems to work again on the 20041020 build with a fresh
profile, so it was only the 20041011 build that was affected, I don't know why
you'd wish to go around threatening antisocial behaviour at folks who're just
trying to help out by reporting bugs.

After all, you do want folks to report bugs, don't you?  If not, I simply won't
bother in future.  I was under the false assumption that reporting bugs in the
spirit of helping out the developers was respectable behaviour, I shall make a
note to refrain from it if it isn't.

Footnote: It doesn't aid you in social circles to express overpowering egotism
and assume that everyone you're replying to is an idiot.  It really doesn't.  In
fact, it only serves to help alienate people.  It doesn't hurt to be curteous to
people who're only trying to help.  Attitudes like that only hurt a community.

Comment 5

[Dan M]

Indeed, apparent inconsistencies in your bug report didn't encourage me to give
you the benefit of the doubt you seem to feel was yours by eminent right. Still,
if you can promise to try not to dismiss my criticisms out of hand, I can
promise to try to be more delicate in the future. We do especially value bug
reports from competent users.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No patch => WFM