264626 - From address changes to different mail account when forwarding mail containing X-Identity-Key header from sender

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Jim Booth]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8a5) Gecko/20041011
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8a5) Gecko/20041011

When forwarding a message from my first listed mail account, sometimes the FROM
address changes to the second account in my list.   Happens consistently with
certain messages (every time I try to forward them) and not with others.  Can't
figure out what's the difference.

Reproducible: Sometimes
Steps to Reproduce:
1. Read a mail message (I noticed it with the inbox in the first mail account --
top of the list.)
2. click the FORWARD button
3. Look in the FROM dropdown box at the top of the compose screen.  It displays
the second email account, not the first. 

Actual Results:  
Wrong FROM email address is shown.  Forwarded message ends up in the SENT box of
the wrong email account.

Expected Results:  
Should send from the same FROM address as the inbox the message was in.

This is a new problem with this build.  Never saw it with my previous build,
20040925.  This build was installed in a new folder.

Comment 1

[Mike Cowperthwaite]

Are the messages which exhibit this problem addressed to the second account?

Comment 2

[Jim Booth]

> Are the messages which exhibit this problem addressed to the second account?
No, they have To: and Envelope to: fields matching the account that received them.  

On further investigation, the common factor is an FCC: HEADER IN THE RECEIVED
MESSAGE.  This is common in certain spam messages. 

Updated summary to reflect this.  Still happening in Seamonkey 2005013005 and
all builds I have used since the original report.

Comment 3

[Mike Cowperthwaite]

Is it just the existence of the FCC header, or does that header point to the 
second account?

Comment 4

[Jim Booth]

All have the format:
   FCC: mailbox://[e-mail]/Sent
   FCC: mailbox://[e-mail]/Sent
   FCC: mailbox://[e-mail]/Sent
   FCC: mailbox://[e-mail]/Sent
   FCC: mailbox://[e-mail]/Sent

None of these addresses have anything to do with my address.

Comment 5

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #4)

(Q1) Which account number is set in "X-Account-Key:" header of these mails?
      - View/Message Source
          Say X-Account-Key: accountXX. (Indicates recieved by "accountXX")
      - See prefs.js and check value of mail.account.accountXX.identities entry
          Say "idYY"
      - See prefs.js and find mail.identity.idYY.useremail entry
     Which mail address is defined for this idenitity number?

(Q2) Which account number is set in "X-Account-Key:" header of other mails?
     Same account number of above mails?
     Which mail address is defined for the identity number?

Comment 6

[Jim Booth]

> Which account number is set in "X-Account-Key:" header of these mails?

X-Account-Key: account7 (id6) in ALL relevant emails, those changing From: and
those not.
account7 refers to the first account in my list (id6)
the second account in my list (the one it keeps switching to) is account1

I forget how I managed to change the order of the accounts in the list.  Maybe
this is relevant?

Comment 7

[Mike Cowperthwaite]

Is the message you're replying to actually in a folder of the account in 
question, of another account, or in local folders?
Also, is this POP mail or IMAP?
Inline forwarding, or as attachment?  Have you ever seen the symptom with Reply?

Comment 8

[Jim Booth]

> Is the message you're replying to actually in a folder of the account in 
> question, of another account, or in local folders?
Usually in INBOX of the first account, but happens from any folder I've tested,
including local folders.  Even if I move a message to another account's folder,
and then forward, From: address changes to my account1 (second one in the list)

>Also, is this POP mail or IMAP?
POP

>Inline forwarding, or as attachment?  
Inline only.  Does NOT happen with Forward as Attachment.

>Have you ever seen the symptom with Reply?
No, can't reproduce with Reply, but I AFAIK it happens 100% of the time
forwarding inline any message with an FCC: header

Comment 9

[Jim Booth]

I just discovered that all the mail messages in question have a header that says:

  X-Identity-Key: id1

If anything, it seems this sould be id6 (see comment 6 above).  No other
messages I've checked even have this header.  Looks like Seamonkey is adding
this header incorrectly when it sees the FCC:. 

Comment 10

[Jim Booth]

I have messages in my account18 inbox that do not refer at all to account7 or
its email address, yet behave identically.  They have the X-Identity-Key: id1
header and the From address changes to account1's when forwarded inline.   

Note: account1 = id1  account7 = id6

Comment 11

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #10)
"X-Identity-Key: idNN" is used for Draft mail by Mozilla/Thunderbird in order to
keep Identitiy information(use which SMTP server, use which FCC folder and so on).
This is removed on send.
(Try create draft, save it, then view mail source.)

Did you try to foward draft mail which you moved to Inbox folder?
If no, this bug can possibly be said as next.
    (a) Remove X-Identity-Key: header on mail receive
        (is it possible when IMAP?)
 or (b) Ignore X-Identity-Key: header in other than Drafts folder on composing

(In reply to comment #6)
> I forget how I managed to change the order of the accounts in the list.
> Maybe this is relevant?
Current logic is (probably, I don't know on RSS account);
 (1) Account set as default mail account
 (2) POP3/IMAP accounts, ordered by mail.accountmanager.accounts
 (3) "Local Folders" account
 (4) News accounts, ordered by mail.accountmanager.accounts

Comment 12

[Jim Booth]

Examining the headers of these messages using a webmail client on the POP box,
before Mozilla has a chance to change them, it turns out that THE MESSAGES
CONTAINED THE "X-Identity-Key: id1" HEADER WHEN RECEIVED, (as well as the FCC:
header) and that apparently fooled Mozilla when forwarding.  

Here is a typical set of headers in the mail as received:
  Received: (...etc.)
  X-Mozilla-Status: 0001
  X-Mozilla-Status2: 00000000
  FCC: mailbox://[e-mail]/Sent
  X-Identity-Key: id1
  Date: Fri, 03 Sep 2004 05:38:18 -0600
  From: Emory Small <[e-mail]>
  X-Mozilla-Draft-Info: internal/draft; vcard=0; receipt=0; uuencode=0
  User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4)
Gecko/20030624 Netscape/7.1 (ax)
  X-Accept-Language: en-us, en
  MIME-Version: 1.0
  To: 
...etc

All messages checked have the same Gecko/20030624 Netscape/7.1 user agent.  

Changing summary to reflect the X-Identity-Key header.

Comment 13

[Mike Cowperthwaite]

(In reply to comment #12)
> it turns out that THE MESSAGES
> CONTAINED THE "X-Identity-Key: id1" HEADER WHEN RECEIVED, (as well as the FCC:
> header) and that apparently fooled Mozilla when forwarding.  
> 
> Here is a typical set of headers in the mail as received:
> [...]
>   User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4)
> Gecko/20030624 Netscape/7.1 (ax)


I'm just revisiting this because it popped up during a search for a different problem.  Your correspondent was using an older version of the client at that time; it may be that Mozilla/Gecko version 1.4 was sending out those proprietary headers (from re-editing a draft, I'd bet).  Has your correspondent updated his client to something more recent?  If so, do you still get the problem with messages from him?

I still think this is a bug; if we're using Forward Inline, we should strip out those Moz-specific headers, not pay attention to them.

Comment 14

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 15

[David]

SeaMonkey (1.1.13) mail composition bug.
I think this bug in SeaMonkey is common to bugs 264626, 79455, 122352, 462589, 279846, 394216 that I have found. 
The mail in Netscape 7.2 works as expected. 
In a SeaMonkey mail program with multiple accounts, quite often the wrong account and "From" address is used when a message is replied to or forwarded on. 
For example:
An email is recieved in account1's inbox.
It is moved to account2's inbox
It is selected and replied to (or forwarded).
Netscape correctly uses account2's "compose in html" setting and the reply-to address. 
SeaMonkey incorrectly uses account1's settings and uses account1's reply-to address. The "from address" can be over-ridden with the pull down box, but the incorrect formatting etc is used when the reply (or forwarded) message is initially generated. 
Selecting a new composition from each account works correctly.
I think that the account settings, from address and formatting etc used when the reply or forwarded message is created, should be from the account where the initial message is currently stored (inbox, draft, template, sent etc), not some obscure address in the header.

Comment 17

[David]

Bug still there in Seamonkey 2.0.10 !!!

Comment 18

[Jeff W]

Still broken in SM 2.2.  Please understand the issue here:

1) at my work computer, I draft an Email in an IMAP account.
2) I go home.  At my home computer, I go to drafts folder.  Email to/from look correct.
3) I open the draft to send it.  The From address has changed to whatever the next one down is on the drop-down associated with the from address)
4) I don't notice the change (hard to see - small black type on blue background).
5) the work email goes to 15 people from a personal Email address.

Please give this some attention when you can?  It's killin' me 8-}

Thanks!
/j

Comment 19

[Brian Keill]

This also happens with Forwarding messages previously sent by me.

When Forwarding an email previously sent, TB uses incorrect account in From Address

I have multiple Accounts in TB. If I forward an email that I've previously sent, it seems to randomly select a FROM account that isn't necessarily the one I originally sent it from.

Reproducible: Always

Steps to Reproduce:
1.Select an email I've already sent
2.Click FORWARD
3.Note FROM address


Expected Results: SHOULD USE ORIGINAL SENT ACCOUNT

RESULTS EXPERIENCED:  
Seemed to randomize using 3 of 9 accounts to place in the SEND address.

Utilized the same address email was originally sent from.

The default account is the email address the emails were originally sent from.

After Shutting down TB and reopening, the seemingly 'randomized' order of accounts that it was using, changed, but then seemed to remain constant after several shut downs and opens.

(NOTE: This was entered previously under 549125 but that was closed and 'merged' with this ticket 264626)

Comment 20

[Terry Mester]

I can confirm this problem with Thunderbird Version 10.0.  When forwarding and also replying to some Messages, the Message Composer doesn't use the Default Identity in the From Bar, but uses another Identity.  This problem is not consistent.  I experience this all the time with E-Mails from kijiji.ca.

Comment 21

[David]

Surely the idea of multiple accounts is that an account is setup for each 
email identity that the user has, ie Home, work, charity etc. 
Then it make sense to keep the mail relating to that identity in folders 
in the relevant account, ie any work related emails would be kept in the 
work\inbox, or work\sent etc. 
Emails could get there by either downloading from different pop servers, 
or by dragging from another account if all incoming mails are consolidated to one server.

Composing a new message when a certain account is highlighted works correctly, 
ie the correct formatting is selected (text/html) and the correct from address 
is selected. 

When it comes to replying or forwarding a message that is highlighted, 
it should work the same way, BUT IT DOESNT !!

Please correct me if I am wrong, but I believe the solution is blatantly obvious and very simple:
1 Ignore the X-Account-Key, or add an option to ignore the X-Account-Key
2 When replying to a message, or forwarding a message, use the same subroutine that creates a new message. 
   That correctly Opens a new edit window
   Uses the correct formatting 
   Uses the correct signature, CC and Bcc addresses
   Uses the correct From address 

To cater for different setups/users then it would be sensible to have some options 
that the user could select in their preferences.