264651 - Links-only type ahead find clears search phrase

Status: RESOLVED INVALID

(Toolkit :: Find Toolbar, defect)

Description

[Ger Teunis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

Links only typeahead clear previous used search phrase.
Find and normal type-ahead (ctrl-F and "/") do not clear the previous used
search phrase.


Reproducible: Always
Steps to Reproduce:
1. Browse to a site
2. Press the "'" key to start type ahead links only
3. Enter a phrase (link name)
4. close find toolbar
5. Press "'" again

Actual Results:  
Previous search phrase is cleared.

Expected Results:  
Like Find and normal type-ahead: it should display the previous entered/used
search phrase.

Comment 1

[Peter van der Woude [:Peter6]]

I'm think this is intended behaviour.
To avoid it, don't close the findbar

Comment 2

[Ger Teunis]

(In reply to comment #1)
> I'm think this is intended behaviour.

I do not think it is intended, when the toolbar is closed after a search and the
user presses the ' key again the search phrase is cleared.

If he/she presses the F3 (find again) button or the "Find Next" button while the
search phrase on the UI is empty it _will_ find the next result of the previous
search phrase, but the UI doesn't show the previous search phrase.

Comment 3

[Michael Clackler]

(In reply to comment #2)
> (In reply to comment #1)
> > I'm think this is intended behaviour.
> 
> I do not think it is intended,

This is the intended behaviour in order to avoid having the focus shift to the
toolbar.  If the toolbar has the focus, hitting <ENTER> will not open the link,
it will act as a find-next.

If the findbar were opened with a previous phrase using links only and the user
needed to delete any or all characters, the findbar would have the focus due to
the delete, and the links would not open.

In order to avoid this problem, the phrase is emptied when the toolbar is opened
using links only typeahead.  This is no different than the "old" typeahead links
only feature.

Comment 4

[Nickolay_Ponomarev]

I don't think it is intended, and it does look strange. Confirming.

Comment 5

[Ger Teunis]

Just a suggestion, still trying to get my build environment up.

I think the modification of the below line in onBrowserKeyPress(evt) 
in /mozilla/browser/base/content/browser.js
will result in not clearing the text after a new ' FAYT.

if (evt.charCode == 47)
     selectFindBar();
     else
     findField.value = "";
     }

into

if (evt.charCode == 39 || evt.charCode == 47)
     selectFindBar();
     else
     findField.value = "";
     }

Comment 6

[Blake Ross]

This behavior is by design.