264663 - when popup information bar is closed using the (x) close button, it reappears after switching to another tab and back

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Hussam Al-Tayeb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

After closing the popup information bar using the new x button, if you switch to
another tab and back, the popup information bar reappears.

PS. this is different than Bug 258592

Reproducible: Always
Steps to Reproduce:
1. Open a new firefox window and open two empty tabs ( tab1 and tab2 )
2. in tab1, open http://www.popuptest.com/popuptest1.html 
3. you should see the popup information bar in tab1.
4. Close the popup information bar in tab1 using the x botton (x botton was
introduced in bug 253326 )
5. Switch to tab2.
6. Switch back to tab1.

Actual Results:  
Popup information bar reappears in tab1.

Expected Results:  
Popup information bar should remain closed in tab1.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

confirming->NEW

Comment 2

[Phil Ringnalda (:philor)]

Possibly significant: the tab you switch away to needs to not have blocked a
popup: switch from blocked-closed to blocked-open or another blocked-closed, and
the first blocked-closed remains closed when you switch back.

Comment 3

[Peter van der Woude [:Peter6]]

just use a blank tab as second one

Comment 4

[Steffen Wilberg]

The plugin finder info bar is not affected by this bug, only the popup info bar.

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 273400 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Connor [:mconnor]]

nice to fix, not high impact, minusing.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Should be relatively easy to fix.

Comment 8

[Phil Ringnalda (:philor)]

*** Bug 292410 has been marked as a duplicate of this bug. ***

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Not so easy to fix... all tabs share a browsermessage (message bar), so the message bar is updated on every tab switch. There's no way of knowing whether the browser message was closed by the user (vs hidden by switching to a tab without one, for example), so storing that state and making sure not to show the message bar on subsequent selections of that tab is impossible. Maybe browsermessage's hide() should fire an notification to be observed by the popup code, much like how it allows something to happen when clicking the "action" button (e.g. edit options).

Comment 10

[zug_treno]

*** Bug 329794 has been marked as a duplicate of this bug. ***

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 343086 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Clarifying summary, suggesting blocking firefox3 as this is seriously annoying behaviour.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

(also upping the priority a little)

Comment 14

[Mike Shaver (:shaver emeritus)]

Nominating for 1.8.1.2: the sliding-into-place behaviour combines quite badly with this on my laptop when viewing complex pages (Zimbra mail UI, f.e.), by making the transition shudder slowly along.  Having that happen every time I go back to the tab is pretty infuriating, and highlights a weakness of our content performance that I think we should be trying pretty hard to keep from the user.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This is the branch-safe, simple patch. On the trunk, I want to fix bug 311851 and rename/document "pageReport", and not rely on setting arbitrary properties on it.

The other option is to remove the call to updatePageReport() in updateCurrentBrowser(), since there's no need to re-add notifications now that they're saved per-tab and not shared. We can't do that yet, though, because the popup blocker status bar button is still shared across tabs, and thus needs to be shown when you switch back to a tab with blocked popups.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Oops, forgot to include a file in the diff.

Comment 17

[Asaf Romano (gone)]

Comment on attachment 244832 [details] [diff] [review]
patch

r=mano

Comment 18

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.735
mozilla/toolkit/content/widgets/browser.xml 	1.97

Comment 19

[Jay Patel [:jay]]

Gavin: Not blocking, but will gladly take patch approval requests. :-)