264670 - Typeaheadfind doesn't work when button has focus

Status: RESOLVED WORKSFORME

(Toolkit :: Find Toolbar, defect)

Description

[Felix Wiemann]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

When a button has the focus, find-as-you-type doesn't work.

Even worse, when typing a space, the button is activated ("clicked"), which
leads to weird and unintended results.  IMO it is sufficient to be able to press
a button using the return key, so typeaheadfind could very well also work when a
button is focused.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Peter van der Woude [:Peter6]]

what button do you talk about ?

Comment 2

[Felix Wiemann]

Any button on a web page.  E.g., the "Commit" below the comment text field in
Bugzilla.

(It happens easily that a button receives the focus when navigating with <Tab>
through the clickable elements on a web page.)

Comment 3

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041016
Firefox/1.0'

Confirming for focus on:

<input type=submit|reset|file|image|button >
<button>

'  or /  does not activate the Find toolbar
only ctrl+F will do

Comment 4

[Jason Spiro]

This bug affects my copy of Firefox 1.0 final.

I'd change it from UNCONFIRMED to NEW but I don't have canconfirm.

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 274809 has been marked as a duplicate of this bug. ***

Comment 6

[Phil Ringnalda (:philor)]

Confirmed, fails in 1.0 and current trunk, works fine in current Seamonkey.

Comment 7

[Michael Clackler]

Attachment: patch to allow FAYT with button focus

This patch removes the blocking of FAYT when a button is focused.

I am not sure what the reasoning was behind the original blocking of the button
focused state.

Comment 8

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050621
Firefox/1.0+ ID:2005062110

fayt does pop up with / now, but not with 

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, I cannot reproduce.

-> WFM.

Comment 10

[Felix Wiemann]

Which version are you using?  I can still reproduce it with 1.0.7.

Comment 11

[Felix Wiemann]

Works for me on 1.5 => OK.