26471 - menu popups not activing and popups on titledbuttons broken

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[fenella]

Linux (2000-02-03-08 M14)
Win (2000-02-03-10 M14)
Steps:
1. From Nova or seamonkey, send myself a message with 2 attachments
list.xls
list1.doc
2. Launch Messenger using the -mail option.
3. From my inbox, select this message
4. From the Envelope of this message, left click on the PIN icon.
5. Left click on the first attachment (or the second one)

Actual result: Nothing happens. 

Expected result: I expect to see the Save Attachment dialog pops up, allowing me
to save the attachment to a selected folder.

This occurs on Linux and Win_nt 4.0.

Have not tested Mac yet (build broken)

Comment 1

[Phil Peterson]

Reassign to jefft. M14, beta1

Comment 2

[jefft]

I haven't touch the save attachment code for ages. Hmmmm...

Comment 3

[jefft]

cc'ing rhp in case he knows something...

Comment 4

[rhp (gone)]

No, actually mscott is the person to bug. I've seen this too.

- rhp

Comment 5

[Scott MacGregor]

This works for me using my build from today....

Comment 6

[Scott MacGregor]

It's an XP toolkit bug / regression from yesterday. There are two problems:
1) popups aren't working on titled buttons anymore. In the message pane (in the
mail 3-pane), when you display a message you can click on an email address
(which is a titled button) and yesterday you would have gotten a popup saying
Add to Address Book, Send Mailto, etc. Today, the titledbutton is DOA.

2) The menu popup associated with the attachment button. This menu popup
actually comes up, but when you try to click on the attachment, the oncommand
handler is not getting fired.

Both of these things worked yesterday.

Re-assigning to xp toolkit. hyatt/evaughan/pinkerton? I'll let Peter figure that
out.

I've changed the summary to be more specific about the problem.

Comment 7

[Peter Trudelle]

assigning to pinkerton as p2 for m14. Shouldn't this be two separate bug reports, 
since there are separate problems, with an 'and' in the summary?  

Comment 8

[Scott MacGregor]

I had assumed the two problems were caused by the same thing since they both
involve popups and the regression happened the same night. Hence only the one
bug report. Feel free to turn this into two separate reports if they aren't
caused by the same regression.

Comment 9

[Mike Pinkerton (not reading bugmail)]

This is yours waterson. The "oncommand" attribute is being set before the node 
has been added to the popup so it doesn't have a mDocument. In 
nsXULElement::AddScriptEventListener, there is code recently added that says:

    if (! mDocument)
        return NS_OK; // XXX

which fails in this case, so no action listener is ever created and the menu 
never fires the oncommand handler. 

Comment 10

[Chris Waterson]

yep, sounds like me.

Comment 11

[Chris Waterson]

mscott: what are the JS Files that are doing this. They need to be whacked.

Comment 12

[Scott MacGregor]

Chris, you want to whack msgHdrViewOverlay.js.

The titledbuttons are generated dynamically in:
InsertEmailAddressUnderEnclosingBox

Comment 13

[Scott MacGregor]

Chris, just to clarify my comments in the JS I pointed you at before. That's for
the popups not activing when you clicked on an email address.

The other part of the regression is with the attachment menupopup (which does
work). However when you click on an element in the attachment menu, the
oncommand never gets fired for it. So we never bring up the save as dialog. This
JS lives in the same file under:
AddAttachmentToMenu

the menu item in the popup is generated dynamically.

Comment 14

[Scott MacGregor]

waterson sent me email describing what needs to be done to fix our JS. I'm going
to take this back from him and do it myself. Thanks Chris.

Comment 15

[Scott MacGregor]

I checked in a work around for this per a discussion with waterson. I'd still
like to see us modify nsXULDocument::AddSubTree so these steps wouldn't be
necessary.

Chris, as part of my fix, I had to set the value for each of my titled buttons
after the titled button was added to the document. This fixes Bug #26586 where
the value of titled buttons that were dynamically added don't always show up
unless the titled button is already part of the xul document.
However, I can see an extra reflow in the message pane after I did this because
I'm setting the value after the button is already visible....

Comment 16

[fenella]

Linux (2000-02-09-08 M14)
Win (2000-02-09-09 M14)
Win32 (2000-02-09-08 M14)
From today's build, I do not see the Pin icon in the Envelope area, reopen the
bug.

Comment 17

[Scott MacGregor]

I just talked to Fenella. She couldn't see the attachment icon because we had a
regression bug where the entire message pane was blank.

That has been fixed and the builds are being respun. So I'm going to reclose
this bug 'cause it is indeed fixed.

Reclosing.

Comment 18

[fenella]

Linux (2000-02-11-11 M14)
Win (2000-02-11-09 M14)
Mac (2000-02-11-12 M14)
This problem has been fixed.