264733 - add assertion for aParentFrame

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Bernd]

I have seen a maybe valid talkback that crashed inside GetFrameAtOrBefore my
guess would be that aParentFrame was null. I would like to assert that a valid
parentframe is passed in in order to catch that crash.

Comment 1

[Bernd]

usually this function will be called with "this" there is only one exception
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/nsTableFrame.cpp#890
I wonder whether I should change the function call from
nsTableColGroupFrame& aColGroupFrame,
to 
nsTableColGroupFrame* aColGroupFrame,
and bail out with an invalid arg assertion if this is null.
Or simply assert and wait till talkback will get some info.
Boris, any comments?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Changing to using a pointer sounds very very good to me.

For the rest, if you can't think of valid cases where it would be null, I'd just
NS_PRECONDITION it.

Comment 3

[Bernd]

Attachment: patch

Comment 4

[Bernd]

Comment on attachment 163214 [details] [diff] [review]
patch

Boris, this is for review just when you have nothing else to do :-).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 163214 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 6

[Bernd]

fix checked in