26476 - Hardcoded strings in Necko (nsSocketTransport, etc.)

Status: VERIFIED FIXED

(Core :: Networking, defect, P2)

Description

[rchen]

"Transferring" hardcoded in
/netwerk/base/src/nsSocketTransport.cpp, line 1933 -- static nsAutoString
frommesg("Transferring data from ");

Please remove it to DTD

Comment 1

[Warren Harris]

There's one of these in nsFileTransport too: "Wrote ..." (and looking at it, it 
doesn't even work right in non-debug mode). There are probably others in necko 
-- and we need to come up with error messages that can be propagated up through 
OnStopRequest. 

Changing summary from: Hardcoded strings in nsSocketTransport.cpp
to: Necko needs internationalization (nsSocketTransport, etc.)

Assigning to Jud. Marking M15 (post beta). I think these don't show up that 
often.

Comment 2

[rchen]

Add bobj, msanz, ftang, tao. 

Necko is NOT internationalized.

Comment 3

[bobj]

Changed summary back to referring to "hardcoded strings".
Internationalization is a big area, this is more descriptive of this
particular bug.

For more on Seamonkey string resources, see
     http://www.mozilla.org/projects/intl/string-resources.html

Comment 4

[rickg]

Not aboslutely essential for Beta. Marking PDT-.

Comment 5

[rchen]

Warren, can you provide us the list of error messages? 

We are localizing Japanese Beta1. If you think these error messages are not 
going to show up to the users, we can wait until M15. Otherwise we prefer to 
have them moved to DTD or properties before beta1. 

Comment 6

[rchen]

Add beta2 keyword and M16 target

Comment 7

[rchen]

*** Bug 33795 has been marked as a duplicate of this bug. ***

Comment 8

[Warren Harris]

Moving to M17 (also beta2).

Comment 9

[leger]

Moving to gagan per valeski- Putting on [nsbeta2+] radar for beta2 fix. 

Comment 10

[Gagan]

ruslan we should coordinate with rchen to also make sure the redirect_loop is 
internationalized as well as any strings that necko handles. 

Comment 11

[ruslan]

Yeah. I'll try to clean this up.

Comment 12

[ruslan]

Fixed

Comment 13

[ruslan]

Oops. Changing status to fixed.

Comment 14

[Tom Everingham]

verif.
NT 2000053008