264765 - nsMsgAccount.cpp cleanup

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Mikael Parknert]

remove some dead code in nsMsgAccounty.cpp

Comment 1

[Mikael Parknert]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 162376 [details] [diff] [review]
patch

Not sure why you asked darin, as opposed to, say, bienvenu for review.

>   nsAutoString val(NS_LITERAL_STRING("[nsIMsgAccount: "));
>-  val.AppendWithConversion(m_accountKey);
>-  val.AppendLiteral("]");
>+  AppendASCIItoUTF16(m_accountKey, val);
>+  val.Append(']');
>   *aResult = ToNewUnicode(val);
As you're changing this anyway here are a couple of alternatives that I
understand might be slightly better string fu: a) nsAutoString val;
val.AppendLiteral("[nsIMsgAccount: "); ... b) *aResult =
ToNewUnicode(NS_LITERAL_STRING("[nsIMsgAccount: "]) +
NS_ConvertASCIItoUTF16(m_accountKey) + NS_LITERAL_STRING("]"));

Comment 3

[Darin Fisher]

Comment on attachment 162376 [details] [diff] [review]
patch

>Index: mailnews/base/src/nsMsgAccount.cpp

>   nsAutoString val(NS_LITERAL_STRING("[nsIMsgAccount: "));

do this instead:

    nsAutoString val;
    val.AssignLiteral("[nsIMsgAccount: ");


sr=darin

Comment 4

[Darin Fisher]

> Not sure why you asked darin, as opposed to, say, bienvenu for review.

yeah, i wondered the same thing... cc'ing bienvenu

Comment 5

[David :Bienvenu]

Comment on attachment 162376 [details] [diff] [review]
patch

looks ok, but:

-  nsresult rv=NS_OK;
+  nsresult rv;

   // need the prefs service to do anything
   rv = getPrefService();

should just go all the way and say

nsresult rv = getPrefService();

Comment 6

[Mikael Parknert]

Attachment: updated with reviewers comments[checked in 20041018]

Thx for the reviews!