264786 - Un-highlight doesn't work on sites with iframes

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Gert-Paul]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041017 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041017 Firefox/1.0

If I try to highlight a word on gathering.tweakers.net and try to un-highlight
it the text stays highlighted. 

Reproducible: Always
Steps to Reproduce:
1. Go to http://gathering.tweakers.net/
2. Open the Find toolbar, e.g. with Ctrl + F
3. Search for Software or another word what can be found on that page
4. Click the highlight button
5. Click the highlight button again
Actual Results:  
The found text stays highlighted

Expected Results:  
The found text should be un-highlighted and return to its normal state

Comment 1

[Gert-Paul]

What I forgot to mention is that it worked until the 15-October build. The
recent changes in the Find Toolbar must have broken this. 

Another exampele of a site where the highlight function doesn't work anymore is
http://forum.tweakzone.nl/

Comment 2

[Peter van der Woude [:Peter6]]

DUPEME

I'm sure there was a bug about <span>'s in a page causing this

Comment 3

[Jesse Ruderman]

Confirmed.  A testcase might be useful.

Comment 4

[Jesse Ruderman]

I have a testcase based on http://gathering.tweakers.net/.  WFM on
http://forum.tweakzone.nl/.

Comment 5

[Jesse Ruderman]

Attachment: testcase

Steps to reproduce with testcase:
1. Load testcase.
2. Ctrl+F, foo, Ctrl+Enter
3. Ctrl+Enter

After step 3, the highlights don't disappear.

Btw, I think this is also a problem on sites with traditional HTML framesets.

Comment 6

[Brian Ryner (not reading)]

Attachment: fix

The global was getting cleared out too early when we had to recurse into
frames.

Comment 7

[Blake Ross]

Comment on attachment 162645 [details] [diff] [review]
fix

Thanks!

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 162645 [details] [diff] [review]
fix

a=asa for aviary checkin.

Comment 9

[Brian Ryner (not reading)]

checked in.

Comment 10

[Greg K.]

Verified fixed using Win FF 1.5.