264822 - "Yahoo" should be "Yahoo!" in included search plugin

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

Steps to reproduce:
1. Drop down the list of search engines in the search bar.

Result: See "Yahoo".
Expected: See "Yahoo!".

Kai pointed out this bug to me.  He said "I thought that FF would look a bit
more polished if it got the name right, down to the punctuation".

Comment 1

[Panos Stokas]

I think FF looks more polished ~without~ such exclamation marks. I find them
quite confusing.

A simple search in Google news
http://news.google.com/news?hl=en&ned=us&q=yahoo&btnG=Search+News shows that
most headlines refer to Yahoo without the exclamation mark.

Comment 2

[flock31070]

I like the exclamation mark. Yahoo never officially separates itself from the exclamation

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I'm guessing Yahoo gets to decide which name it uses, right?

Comment 4

[Rafael Ebron (:rebron)]

This might be WONTFIX, will check w/ Yahoo

Comment 5

[bio_tube]

The companies name is Yahoo! Inc. The following was taken from a copyright notice at the bottom of the page:

Copyright © 1994-2006 Yahoo! Inc. All rights reserved. Terms of Service - Copyright/IP Policy - Guidelines - Ad Feedback
NOTICE: We collect personal information on this site.
To learn more about how we use your information, see our Privacy Policy

Comment 6

[bio_tube]

Attachment: Modified Yahoo! search plugin with correct name.

Corrected error posted corrected search plugin.

Comment 7

[(no longer active)]

Attachment: "Yahoo!": the en-US locale

The patch to add the exclamation mark to Yahoo in the en-US locale

Comment 8

[(no longer active)]

Attachment: "Yahoo!": the rest of the locales

The patch to add the exclamation marks for the rest of the locales

Comment 9

[:Gavin Sharp [email: [e-mail]]]

It should really be up to Yahoo to determine what string they want to use here. I'll see if I can get a contact there to comment.

Comment 10

[(no longer active)]

Hmmm, "Yahoo! Inc" is their corporate name, and "Yahoo!" is their brand name.

http://en.wikipedia.org/wiki/Yahoo!

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 284774 [details] [diff] [review]
"Yahoo!": the en-US locale

I can r- this already, changing the name would require changes in region.properties, same for the l10n patch.

Let's wait with a new patch for gavin, let's see if this bug is actually something we want to fix.

Comment 12

[(no longer active)]

Attachment: "Yahoo!": the en-US locale (with region.properties modifications)

The updated patch for the en-US locale with region.properties modifications.

Comment 13

[(no longer active)]

Attachment: "Yahoo!": the rest of the locales (with region.properties modifications)

The updated patch for the en-US locale with region.properties modifications.

Comment 14

[Kev Needham [:kev]]

Hey folks,

Per discussions with Yahoo! corporate marketing, the correct label should be "Yahoo!" with the exclamation mark. Please use the "Yahoo!" label for the plugin. 

If additional information is required, please let me know.

kev (partner distributions)

Comment 15

[(no longer active)]

(In reply to comment #14)
> Hey folks,
> 
> Per discussions with Yahoo! corporate marketing, the correct label should be
> "Yahoo!" with the exclamation mark. Please use the "Yahoo!" label for the
> plugin. 
> 
> If additional information is required, please let me know.
> 
> kev (partner distributions)
> 

Gavin, Axel, waiting for your reviews on the patches...

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 285263 [details] [diff] [review]
"Yahoo!": the rest of the locales (with region.properties modifications)

We're in the middle of ramping up for Beta 1, and I need to chat with a few folks on how we make sure that we transport the settings we have in Firefox 2 onto Firefox 3.

I'm definitly not going to take the chunks to the .src files, and quite a few yahoo.xml can be just removed, as they won't be used anyway. Sorry for the confusion here.

Anyway, I did want to comment on this, it's been rotting in my queue for a bit.

Note, as we're using the yahoo.xml plugin in en-US from l10n, the l10n and the en-US patch need to land in synch.

Comment 17

[(no longer active)]

Any updates on this?

Comment 18

[Axel Hecht [:Pike]]

Making this depend on bug 413331, cleanup of searchplugins in l10n.

Comment 19

[Axel Hecht [:Pike]]

Comment on attachment 285263 [details] [diff] [review]
"Yahoo!": the rest of the locales (with region.properties modifications)

r- now that this can finally get a new patch.

Comment 20

[(no longer active)]

Comment on attachment 285257 [details] [diff] [review]
"Yahoo!": the en-US locale (with region.properties modifications)

This should be fine, I guess.  I'll post an updated patch for l10n soon.

Comment 21

[:Gavin Sharp [email: [e-mail]]]

I'm not sure that we can do this without breaking the user's saved ordering. The search service uses the name as the search plugin's unique ID, so changing the name would mean that the search service will lose any engine metadata we might have stored (alias, order, etc.) when the user upgrades from a version containing the "Yahoo" engine to a version containing the "Yahoo!" one.

I think ideally we'd use some kind of unique ID that's not tied to the display name to enable these kinds of fixes, but we're not there yet, and I don't see any easy solutions.

Comment 22

[Axel Hecht [:Pike]]

Comment on attachment 285257 [details] [diff] [review]
"Yahoo!": the en-US locale (with region.properties modifications)

r-, based on Gavin's comment. Basically, convince Gavin first here.

Comment 23

[Kev Needham [:kev]]

FWIW, throwing my weight in with Gavin here. Until we can separate the title of the plugin from the user pref, this is a wontfix because we can/will break things for the user.

Comment 24

[(no longer active)]

Updating to reality...

Comment 25

[Francesco Lodolo [:flod]]

Is this still valid? I found a lot of "Yahoo" without exclamation marks in Yahoo web properties nowadays.

Comment 26

[Pranav]

Attachment: Bug 264822 Changed "yahoo" to "Yahoo!" in the search box

Comment 27

[Francesco Lodolo [:flod]]

I think any review should wait for a clarification in bug 903082 comment 53 and following.

Comment 28

[David Lawrence [:dkl]]

Comment on attachment 826703 [details] [diff] [review]
Bug 264822 Changed "yahoo" to "Yahoo!" in the search box

Sorry. Not the right person to review this.

Comment 29

[:Gavin Sharp [email: [e-mail]]]

We don't need to do this at the moment.